build/android/PRESUBMIT.py - Issue 197693002: [Android] Lint build/android/gyp/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/PRESUBMIT.py

Issue 197693002: [Android] Lint build/android/gyp/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: now using extra_paths_list to avoid F0401s Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for android buildbot.	5 """Presubmit script for android buildbot.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for

8 details on the presubmit API built into gcl.	8 details on the presubmit API built into gcl.

9 """	9 """

10	10

(...skipping 25 matching lines...) Expand all Loading...
36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)	36 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs)

37	37

38 output.extend(input_api.canned_checks.RunPylint(	38 output.extend(input_api.canned_checks.RunPylint(

39 input_api,	39 input_api,

40 output_api,	40 output_api,

41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.\.py$', r'pylib/.\.py$'],	41 white_list=[r'PRESUBMIT\.py$', r'buildbot/.\.py$', r'pylib/.\.py$'],

42 black_list=[r'pylib/symbols/.*\.py$'],	42 black_list=[r'pylib/symbols/.*\.py$'],

43 extra_paths_list=[	43 extra_paths_list=[

44 J(), J('..', '..', 'third_party', 'android_testrunner'),	44 J(), J('..', '..', 'third_party', 'android_testrunner'),

45 J('buildbot')]))	45 J('buildbot')]))

	46 output.extend(input_api.canned_checks.RunPylint(

	47 input_api,

	48 output_api,

	49 white_list=[r'gyp/.*\.py$'],

	50 extra_paths_list=[J('gyp')]))

46	51

47 output.extend(input_api.canned_checks.RunUnitTestsInDirectory(	52 output.extend(input_api.canned_checks.RunUnitTestsInDirectory(

48 input_api, output_api, J('buildbot', 'tests')))	53 input_api, output_api, J('buildbot', 'tests')))

49 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))	54 output.extend(_CheckDeletionsOnlyFiles(input_api, output_api))

50 return output	55 return output

51	56

52	57

53 def CheckChangeOnUpload(input_api, output_api):	58 def CheckChangeOnUpload(input_api, output_api):

54 return CommonChecks(input_api, output_api)	59 return CommonChecks(input_api, output_api)

55	60

56	61

57 def CheckChangeOnCommit(input_api, output_api):	62 def CheckChangeOnCommit(input_api, output_api):

58 return CommonChecks(input_api, output_api)	63 return CommonChecks(input_api, output_api)

OLD	NEW

« no previous file with comments | « no previous file | build/android/gyp/ant.py » ('j') | no next file with comments »