Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: build/android/gyp/javac.py

Issue 197693002: [Android] Lint build/android/gyp/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # 2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved. 3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 import fnmatch 7 import fnmatch
8 import optparse 8 import optparse
9 import os 9 import os
10 import sys 10 import sys
11 11
12 # pylint: disable=F0401
12 from util import build_utils 13 from util import build_utils
13 from util import md5_check 14 from util import md5_check
15 # pylint: enable=F0401
14 16
15 17
16 def DoJavac(options): 18 def DoJavac(options):
17 output_dir = options.output_dir 19 output_dir = options.output_dir
18 20
19 src_dirs = build_utils.ParseGypList(options.src_dirs) 21 src_dirs = build_utils.ParseGypList(options.src_dirs)
20 java_files = build_utils.FindInDirectories(src_dirs, '*.java') 22 java_files = build_utils.FindInDirectories(src_dirs, '*.java')
21 if options.javac_includes: 23 if options.javac_includes:
22 javac_includes = build_utils.ParseGypList(options.javac_includes) 24 javac_includes = build_utils.ParseGypList(options.javac_includes)
23 filtered_java_files = [] 25 filtered_java_files = []
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 build_utils.CheckOutput(javac_cmd, print_stdout=options.chromium_code) 69 build_utils.CheckOutput(javac_cmd, print_stdout=options.chromium_code)
68 70
69 record_path = '%s/javac.md5.stamp' % options.output_dir 71 record_path = '%s/javac.md5.stamp' % options.output_dir
70 md5_check.CallAndRecordIfStale( 72 md5_check.CallAndRecordIfStale(
71 Compile, 73 Compile,
72 record_path=record_path, 74 record_path=record_path,
73 input_paths=java_files + jar_inputs, 75 input_paths=java_files + jar_inputs,
74 input_strings=javac_cmd) 76 input_strings=javac_cmd)
75 77
76 78
77 def main(argv): 79 def main():
78 parser = optparse.OptionParser() 80 parser = optparse.OptionParser()
79 parser.add_option('--src-dirs', help='Directories containing java files.') 81 parser.add_option('--src-dirs', help='Directories containing java files.')
80 parser.add_option('--javac-includes', 82 parser.add_option('--javac-includes',
81 help='A list of file patterns. If provided, only java files that match' + 83 help='A list of file patterns. If provided, only java files that match' +
82 'one of the patterns will be compiled.') 84 'one of the patterns will be compiled.')
83 parser.add_option('--classpath', help='Classpath for javac.') 85 parser.add_option('--classpath', help='Classpath for javac.')
84 parser.add_option('--output-dir', help='Directory for javac output.') 86 parser.add_option('--output-dir', help='Directory for javac output.')
85 parser.add_option('--stamp', help='Path to touch on success.') 87 parser.add_option('--stamp', help='Path to touch on success.')
86 parser.add_option('--chromium-code', type='int', help='Whether code being ' 88 parser.add_option('--chromium-code', type='int', help='Whether code being '
87 'compiled should be built with stricter warnings for ' 89 'compiled should be built with stricter warnings for '
88 'chromium code.') 90 'chromium code.')
89 91
90 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja. 92 # TODO(newt): remove this once http://crbug.com/177552 is fixed in ninja.
91 parser.add_option('--ignore', help='Ignored.') 93 parser.add_option('--ignore', help='Ignored.')
92 94
93 options, _ = parser.parse_args() 95 options, _ = parser.parse_args()
94 96
95 DoJavac(options) 97 DoJavac(options)
96 98
97 if options.stamp: 99 if options.stamp:
98 build_utils.Touch(options.stamp) 100 build_utils.Touch(options.stamp)
99 101
100 102
101 if __name__ == '__main__': 103 if __name__ == '__main__':
102 sys.exit(main(sys.argv)) 104 sys.exit(main())
103 105
104 106
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698