Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: ios/chrome/browser/experimental_flags.mm

Issue 1976903002: Keep All Bookmarks panel visible by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/experimental_flags.mm
diff --git a/ios/chrome/browser/experimental_flags.mm b/ios/chrome/browser/experimental_flags.mm
index 9218e898a40d629ddfbf52486cbba7aba606a721..1081ddd752fcbbd8eadbe1520658aea7e5ed58e3 100644
--- a/ios/chrome/browser/experimental_flags.mm
+++ b/ios/chrome/browser/experimental_flags.mm
@@ -110,10 +110,13 @@ bool IsAllBookmarksEnabled() {
return false;
}
- // Check if the finch experiment is turned on. Flag is off by default.
+ // Check if the finch experiment exists.
std::string group_name =
base::FieldTrialList::FindFullName("RemoveAllBookmarks");
+ if (group_name.empty()) {
+ return true; // If no finch experiment, keep all bookmarks enabled.
+ }
return base::StartsWith(group_name, "Enabled",
base::CompareCase::INSENSITIVE_ASCII);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698