Issue 19769005: add FilterLevel API to SkPaint, replacing various Flag bits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19769005: add FilterLevel API to SkPaint, replacing various Flag bits (Closed)

Created:
7 years, 5 months ago by reed1

Modified:
7 years, 5 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add FilterLevel API to SkPaint, replacing various Flag bits BUG= R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=10138

Patch Set 2 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -8 lines)			Patch
	M	include/core/SkPaint.h	View	1	3 chunks	+40 lines, -4 lines	0 comments	Download
	M	src/core/SkPaint.cpp	View		2 chunks	+23 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm https://codereview.chromium.org/19769005/diff/1/include/core/SkPaint.h File include/core/SkPaint.h (right): https://codereview.chromium.org/19769005/diff/1/include/core/SkPaint.h#newcode103 include/core/SkPaint.h:103: kDither_Flag = 0x04, //!< mask to enable dithering ...

7 years, 5 months ago (2013-07-18 13:42:12 UTC) #2

reed1

On 2013/07/18 13:42:12, bsalomon wrote: > lgtm > > https://codereview.chromium.org/19769005/diff/1/include/core/SkPaint.h > File include/core/SkPaint.h (right): > ...

7 years, 5 months ago (2013-07-18 13:44:39 UTC) #3

reed1

7 years, 5 months ago (2013-07-18 13:47:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r10138 (presubmit successful).

Expand Messages | Collapse Messages

Issue 19769005: add FilterLevel API to SkPaint, replacing various Flag bits (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages