Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1976883002: Add PRESUBMIT check for including non-Blink variant mojoms in Blink. (Closed)

Created:
4 years, 7 months ago by dcheng
Modified:
4 years, 7 months ago
Reviewers:
haraken, tkent, esprehn
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PRESUBMIT check for including non-Blink variant mojoms in Blink. Blink code should only use the Blink variants of the generated mojom headers. BUG=610421 R=esprehn@chromium.org,haraken@chromium.org,tkent@chromium.org Committed: https://crrev.com/378010a9e3fcf55ec9b63183e06ddc1848734d28 Cr-Commit-Position: refs/heads/master@{#393449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M third_party/WebKit/PRESUBMIT.py View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dcheng
+esprehn, +haraken for review +tkent for OWNERS
4 years, 7 months ago (2016-05-13 04:07:00 UTC) #3
esprehn
Lgtm, thanks for doing this!
4 years, 7 months ago (2016-05-13 04:08:48 UTC) #4
tkent
lgtm
4 years, 7 months ago (2016-05-13 04:10:15 UTC) #5
haraken
LGTM
4 years, 7 months ago (2016-05-13 04:11:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976883002/1
4 years, 7 months ago (2016-05-13 04:13:14 UTC) #8
dcheng
(I manually tested that this PRESUBMIT works, I don't think there's any automated tests, unfortunately)
4 years, 7 months ago (2016-05-13 04:13:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 05:09:58 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 05:11:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/378010a9e3fcf55ec9b63183e06ddc1848734d28
Cr-Commit-Position: refs/heads/master@{#393449}

Powered by Google App Engine
This is Rietveld 408576698