Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issue 1976863002: Update ChooserBubbleUiController to use FormatOriginForSecurityDisplay (Closed)

Created:
4 years, 7 months ago by juncai
Modified:
4 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update ChooserBubbleUiController to use FormatOriginForSecurityDisplay Since FormatOriginForSecurityDisplay() was added to take url::Origin as the parameter, ChooserBubbleUiController can use it to display the origin on the chooser bubble title. BUG=609521, 529950 Committed: https://crrev.com/9e20b35e488e98992cc193f4ac239425d9cf23c5 Cr-Commit-Position: refs/heads/master@{#393580}

Patch Set 1 : updated ChooserBubbleUiController to use FormatOriginForSecurityDisplay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
juncai
Please take a look.
4 years, 7 months ago (2016-05-13 02:33:17 UTC) #2
Robert Sesek
lgtm
4 years, 7 months ago (2016-05-13 16:49:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976863002/1
4 years, 7 months ago (2016-05-13 17:41:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 18:08:46 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 18:11:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e20b35e488e98992cc193f4ac239425d9cf23c5
Cr-Commit-Position: refs/heads/master@{#393580}

Powered by Google App Engine
This is Rietveld 408576698