remoting/android/java/src/org/chromium/chromoting/HostListManager.java - Issue 1976853002: [Remoting Android] Refactor OAuth Token Fetching Code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/HostListManager.java

Issue 1976853002: [Remoting Android] Refactor OAuth Token Fetching Code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reviewer's Feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « remoting/android/java/src/org/chromium/chromoting/Chromoting.java ('k') | remoting/android/java/src/org/chromium/chromoting/OAuthTokenConsumer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/android/java/src/org/chromium/chromoting/HostListManager.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/HostListManager.java b/remoting/android/java/src/org/chromium/chromoting/HostListManager.java

index 64fb6658cbc830d48a6b8fa1e18725b7b9721eed..4cd703be82efd4e71601d1ca6404ebcfaed8490a 100644

--- a/remoting/android/java/src/org/chromium/chromoting/HostListManager.java

+++ b/remoting/android/java/src/org/chromium/chromoting/HostListManager.java

@@ -273,8 +273,10 @@ public class HostListManager {

// Listen for the server to respond.

int status = link.getResponseCode();

+ // TODO(yuweih): Turn this switch statement into range testing. e.g. 200-299 = OK.

switch (status) {

case HttpURLConnection.HTTP_OK: // 200

+ case HttpURLConnection.HTTP_NO_CONTENT: // 204

break;

case HttpURLConnection.HTTP_UNAUTHORIZED: // 401

error = Error.AUTH_FAILED;