Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1976813002: [esnext] Fix super in async arrow functions (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
Reviewers:
caitp (gmail), neis
CC:
Benedikt Meurer, Michael Hablich, Michael Achenbach, oth, rmcilroy, v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[esnext] Fix super in async arrow functions Ordinary arrow functions have 'undefined' in their frame's receiver. Generators restore the receiver to the frame based on one passed in when they are constructed in CreateJSGeneratorObject. This patch makes async arrow functions pass in 'undefined' for their receiver so that they have the same behavior as ordinary arrow functions, which avoids the issue of encountering TDZ when calling an async arrow function in a subclass constructor before a super call has returned. BUG=v8:4483 Committed: https://crrev.com/690922c95966b6789053ab27c8cf21dfbd0080c6 Cr-Commit-Position: refs/heads/master@{#36264}

Patch Set 1 #

Patch Set 2 : Fix dependencies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/parsing/parser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/parsing/parser.cc View 1 3 chunks +7 lines, -4 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
Dan Ehrenberg
4 years, 7 months ago (2016-05-12 23:30:05 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976813002/20001
4 years, 7 months ago (2016-05-12 23:30:19 UTC) #4
caitp (gmail)
Looks good here
4 years, 7 months ago (2016-05-12 23:33:34 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 00:03:22 UTC) #7
neis
lgtm
4 years, 7 months ago (2016-05-13 09:00:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976813002/20001
4 years, 7 months ago (2016-05-17 00:42:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-17 01:14:35 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 01:16:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/690922c95966b6789053ab27c8cf21dfbd0080c6
Cr-Commit-Position: refs/heads/master@{#36264}

Powered by Google App Engine
This is Rietveld 408576698