Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1976803003: sync compositor: Move DeliverMessages to OutputSurface (Closed)

Created:
4 years, 7 months ago by boliu
Modified:
4 years, 7 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync compositor: Move DeliverMessages to OutputSurface OutputSurface can send IPC messages now and doesn't need to hop through the proxy. Minor refactor. BUG=609977 Committed: https://crrev.com/5965c8d1f5bea3b62be1f6fc8fb4d75564988e90 Cr-Commit-Position: refs/heads/master@{#393694}

Patch Set 1 #

Patch Set 2 : unregister activation callback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -33 lines) Patch
M content/renderer/android/synchronous_compositor_output_surface.h View 4 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/android/synchronous_compositor_output_surface.cc View 1 5 chunks +20 lines, -9 lines 1 comment Download
M content/renderer/android/synchronous_compositor_proxy.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/android/synchronous_compositor_proxy.cc View 1 4 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
boliu
ptal
4 years, 7 months ago (2016-05-13 00:42:54 UTC) #2
boliu
https://codereview.chromium.org/1976803003/diff/20001/content/renderer/android/synchronous_compositor_output_surface.cc File content/renderer/android/synchronous_compositor_output_surface.cc (right): https://codereview.chromium.org/1976803003/diff/20001/content/renderer/android/synchronous_compositor_output_surface.cc#newcode144 content/renderer/android/synchronous_compositor_output_surface.cc:144: client_->SetTreeActivationCallback(base::Closure()); added this line
4 years, 7 months ago (2016-05-13 22:40:21 UTC) #3
hush (inactive)
lgtm
4 years, 7 months ago (2016-05-13 23:03:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976803003/20001
4 years, 7 months ago (2016-05-13 23:04:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 23:58:29 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 00:00:02 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5965c8d1f5bea3b62be1f6fc8fb4d75564988e90
Cr-Commit-Position: refs/heads/master@{#393694}

Powered by Google App Engine
This is Rietveld 408576698