Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1976733002: MD Settings: combine title and ways of closing Bluetooth device dialog (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: combine title and ways of closing Bluetooth device dialog R=stevenjb@chromium.org BUG=602538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/94c2e7d73b8c3996f7c878c539329ebac807c860 Cr-Commit-Position: refs/heads/master@{#393716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -48 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html View 6 chunks +7 lines, -37 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js View 4 chunks +28 lines, -10 lines 0 comments Download
M chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1974193002 Patch 20001

Messages

Total messages: 9 (3 generated)
Dan Beam
4 years, 7 months ago (2016-05-12 21:05:23 UTC) #2
Dan Beam
ping
4 years, 7 months ago (2016-05-13 23:33:56 UTC) #3
stevenjb
Cheers. lgtm.
4 years, 7 months ago (2016-05-13 23:39:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976733002/1
4 years, 7 months ago (2016-05-13 23:52:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-14 01:03:08 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 01:05:10 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/94c2e7d73b8c3996f7c878c539329ebac807c860
Cr-Commit-Position: refs/heads/master@{#393716}

Powered by Google App Engine
This is Rietveld 408576698