components/mus/public/interfaces/gpu_service.mojom - Issue 1976703003: Impl mus::mojom::GpuService to enable using Chrome IPC version gpu CmdBuf in mus

Unified Diff: components/mus/public/interfaces/gpu_service.mojom

Issue 1976703003: Impl mus::mojom::GpuService to enable using Chrome IPC version gpu CmdBuf in mus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/mus/public/cpp/lib/gpu_service.cc ('K') | « components/mus/public/cpp/window_tree_host_factory.h ('k') | components/mus/surfaces/BUILD.gn » ('j') | components/mus/surfaces/surfaces_context_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/mus/public/interfaces/gpu_service.mojom

diff --git a/components/mus/public/interfaces/gpu_service.mojom b/components/mus/public/interfaces/gpu_service.mojom

index 89f7923dba650aa61901a36a4106fe1d3978df02..65b67f64a08f1b18ef9a4e333b415dbd84382cb2 100644

--- a/components/mus/public/interfaces/gpu_service.mojom

+++ b/components/mus/public/interfaces/gpu_service.mojom

@@ -14,10 +14,10 @@ interface GpuService {

// Tells the GPU service to create a new channel for communication with a

// client. The GPU service responds asynchronously with IPC handle and

// GPUInfo.

- EstablishGpuChannel(bool prempts,

+ EstablishGpuChannel(bool preempts,

bool allow_view_command_buffers,

bool allow_real_time_streams)

piman 2016/05/24 22:46:54 These 3 bools are security-sensitive. In Chrome we

Fady Samuel 2016/05/25 17:06:47 Could we split this off to two interfaces? Mus Win

Peng 2016/05/25 19:42:56 I think we could add the private interface later(w

Peng 2016/05/25 19:42:56 Done.

- => (ChannelHandle channel_handle, GpuInfo gpu_info);

+ => (int32 client_id, ChannelHandle channel_handle, GpuInfo? gpu_info);

// Tells the GPU service to create a new GPU memory buffer.

CreateGpuMemoryBuffer(GpuMemoryBufferId id,