Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1976683004: Revert "Write adjusted range back to module" (Closed)

Created:
4 years, 7 months ago by michaelbai
Modified:
4 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Write adjusted range back to module" This is no right fix, we shouldn't allow module overlap. This reverts commit 4f417c8c0ffceb6c2516c6ef00cd91ca5746d852. BUG=606972 R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/a875991e73835d2ad3ba277b53b8121fd1ee06ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M src/google_breakpad/processor/minidump.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/processor/minidump.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
michaelbai
4 years, 7 months ago (2016-05-13 16:33:08 UTC) #3
Mark Mentovai
LGTM
4 years, 7 months ago (2016-05-13 16:41:44 UTC) #4
michaelbai
Please help me to land it.
4 years, 7 months ago (2016-05-13 16:42:59 UTC) #5
Mark Mentovai
Committed patchset #1 (id:1) manually as a875991e73835d2ad3ba277b53b8121fd1ee06ab (presubmit successful).
4 years, 7 months ago (2016-05-13 16:45:49 UTC) #7
Primiano Tucci (use gerrit)
On 2016/05/13 16:45:49, Mark Mentovai wrote: > Committed patchset #1 (id:1) manually as > a875991e73835d2ad3ba277b53b8121fd1ee06ab ...
4 years, 7 months ago (2016-05-13 17:05:06 UTC) #8
michaelbai
4 years, 7 months ago (2016-05-13 17:07:04 UTC) #9
Message was sent while issue was closed.
On 2016/05/13 17:05:06, Primiano Tucci wrote:
> On 2016/05/13 16:45:49, Mark Mentovai wrote:
> > Committed patchset #1 (id:1) manually as
> > a875991e73835d2ad3ba277b53b8121fd1ee06ab (presubmit successful).
> 
> micheal, also please roll breakpad in chrome, so minidump_Stackwalk will match
> the current state of things.

Yes, it is here https://codereview.chromium.org/1978803003/

Powered by Google App Engine
This is Rietveld 408576698