Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1976673002: Roll WebRTC 12681:12729, Libjingle 12581:12686 (Closed)

Created:
4 years, 7 months ago by Taylor_Brandstetter
Modified:
4 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll WebRTC 12681:12729, Libjingle 12581:12686 WebRTC 12681:12729 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/0ddcbd4..a52f9db Libjingle 12581:12686 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/ca22ce2..3c48e13 Committed: https://crrev.com/79f740b7d0316cb500af3ee9134f4b5bf93ccc1c Cr-Commit-Position: refs/heads/master@{#393548}

Patch Set 1 #

Patch Set 2 : Fixing remoting_unittests #

Patch Set 3 : Update WebRTC to 12729 (the dependent WebRTC CL was reverted and relanded) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M DEPS View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/http_ice_config_request_unittest.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Taylor_Brandstetter
PTAL. I added operator== implementations in webrtc and they conflict with the ones defined here ...
4 years, 7 months ago (2016-05-12 18:38:29 UTC) #3
Sergey Ulanov
lgtm
4 years, 7 months ago (2016-05-12 20:41:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976673002/40001
4 years, 7 months ago (2016-05-13 15:19:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976673002/40001
4 years, 7 months ago (2016-05-13 16:34:28 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-13 16:38:32 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 16:40:13 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/79f740b7d0316cb500af3ee9134f4b5bf93ccc1c
Cr-Commit-Position: refs/heads/master@{#393548}

Powered by Google App Engine
This is Rietveld 408576698