Heap maps: add VM service message.

runtime/vm/pages.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/pages.h"
 
 #include "platform/assert.h"
 #include "vm/compiler_stats.h"
 #include "vm/gc_marker.h"
 #include "vm/gc_sweeper.h"
@@ skipping 410 matching lines @@
   space.AddProperty("name", "PageSpace");
   space.AddProperty("user_name", "old");
   space.AddProperty("collections", collections());
   space.AddProperty("used", UsedInWords() * kWordSize);
   space.AddProperty("capacity", CapacityInWords() * kWordSize);
   space.AddProperty("external", ExternalInWords() * kWordSize);
   space.AddProperty("time", MicrosecondsToSeconds(gc_time_micros()));
 }
 
 
+class HeapMapAsJSONVisitor : public ObjectVisitor {
+ public:
+  explicit HeapMapAsJSONVisitor(JSONArray* array)
+      : ObjectVisitor(NULL), array_(array) {}
+  virtual void VisitObject(RawObject* obj) {
+    array_->AddValue(obj->Size() / kObjectAlignment);
+    // Freelist is most interesting, so map it to a fixed unused value.
+    ASSERT(0 == kIllegalCid);
+    array_->AddValue(obj->IsFreeListElement() ? 0 : obj->GetClassId());

[Cutch, 2014/03/12 19:02:02]

I'm concerned about mapping kFreeListElement to kIllegalCid.

What if kept it as kFreeListElement include the index in the HeapMap message
(see below).

[koda, 2014/03/12 19:08:01]

Good idea. Done.

+  }
+ private:
+  JSONArray* array_;
+};
+
+
+void PageSpace::PrintHeapMapToJSONStream(JSONStream* stream) {
+  JSONObject heap_map(stream);
+  heap_map.AddProperty("type", "HeapMap");
+  heap_map.AddProperty("id", "heapmap");

[Cutch, 2014/03/12 19:02:02]

heap_map.AddProperty("free_class_id", kFreeListElement);

[koda, 2014/03/12 19:08:01]

Done.

+  {
+    JSONArray all_pages(&heap_map, "pages");

[Cutch, 2014/03/12 19:02:02]

Maybe add a comment here saying the format of "pages" is:

[page0, page1, ..., pageN]

Format of a page is:

[size, class id, ..., size, class id]

[koda, 2014/03/12 19:08:01]

Done.

+    for (HeapPage* page = pages_; page != NULL; page = page->next()) {
+      JSONArray page_map(&all_pages);
+      HeapMapAsJSONVisitor printer(&page_map);
+      page->VisitObjects(&printer);
+    }
+  }
+}
+
+
 bool PageSpace::ShouldCollectCode() {
   // Try to collect code if enough time has passed since the last attempt.
   const int64_t start = OS::GetCurrentTimeMicros();
   const int64_t last_code_collection_in_us =
       page_space_controller_.last_code_collection_in_us();
 
   if ((start - last_code_collection_in_us) >
       FLAG_code_collection_interval_in_us) {
     if (FLAG_log_code_drop) {
       OS::Print("Trying to detach code.\n");
@@ skipping 262 matching lines @@
     return 0;
   } else {
     ASSERT(total_time >= gc_time);
     int result= static_cast<int>((static_cast<double>(gc_time) /
                              static_cast<double>(total_time)) * 100);
     return result;
   }
 }
 
 }  // namespace dart