Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2402)

Unified Diff: content/renderer/render_frame_impl_browsertest.cc

Issue 1976573002: Only use pending navigation params for browser-initiated navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: consistency Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl_browsertest.cc
diff --git a/content/renderer/render_frame_impl_browsertest.cc b/content/renderer/render_frame_impl_browsertest.cc
index 519f7f2d7f968bbaf1072e9c17871c3f5267c2d5..2a853c169037884711d27c025a54b8cfa10a5219 100644
--- a/content/renderer/render_frame_impl_browsertest.cc
+++ b/content/renderer/render_frame_impl_browsertest.cc
@@ -197,10 +197,11 @@ TEST_F(RenderFrameImplTest, LoFiNotUpdatedOnSubframeCommits) {
// The main frame's and subframe's LoFi states should stay the same on
// navigations within the page.
frame()->didNavigateWithinPage(frame()->GetWebFrame(), item,
- blink::WebStandardCommit);
+ blink::WebStandardCommit, true);
EXPECT_TRUE(frame()->IsUsingLoFi());
GetMainRenderFrame()->didNavigateWithinPage(
- GetMainRenderFrame()->GetWebFrame(), item, blink::WebStandardCommit);
+ GetMainRenderFrame()->GetWebFrame(), item, blink::WebStandardCommit,
+ true);
EXPECT_TRUE(GetMainRenderFrame()->IsUsingLoFi());
// The subframe's LoFi state should not be reset on commit.
@@ -257,10 +258,11 @@ TEST_F(RenderFrameImplTest, EffectiveConnectionType) {
// The main frame's and subframe's effective connection type should stay the
// same on navigations within the page.
frame()->didNavigateWithinPage(frame()->GetWebFrame(), item,
- blink::WebStandardCommit);
+ blink::WebStandardCommit, true);
EXPECT_EQ(tests[i].type, frame()->getEffectiveConnectionType());
GetMainRenderFrame()->didNavigateWithinPage(
- GetMainRenderFrame()->GetWebFrame(), item, blink::WebStandardCommit);
+ GetMainRenderFrame()->GetWebFrame(), item, blink::WebStandardCommit,
+ true);
EXPECT_EQ(tests[i].type, frame()->getEffectiveConnectionType());
// The subframe's effective connection type should not be reset on commit.
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/test/data/navigation_controller/beforeunload_replacestate_1.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698