Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/renderer/content_settings_observer_browsertest.cc

Issue 1976573002: Only use pending navigation params for browser-initiated navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: consistency Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/content_settings_observer_browsertest.cc
diff --git a/chrome/renderer/content_settings_observer_browsertest.cc b/chrome/renderer/content_settings_observer_browsertest.cc
index d49ff98b0ec44dccf37c1c96a51a4c37205189d7..1728401ef49685bb714453ae0d6d12f9ecc9808f 100644
--- a/chrome/renderer/content_settings_observer_browsertest.cc
+++ b/chrome/renderer/content_settings_observer_browsertest.cc
@@ -158,7 +158,7 @@ TEST_F(ChromeRenderViewTest, PluginsTemporarilyAllowed) {
EXPECT_FALSE(observer->IsPluginTemporarilyAllowed(bar_plugin));
// Simulate a navigation within the page.
- DidNavigateWithinPage(GetMainFrame(), true);
+ DidNavigateWithinPage(GetMainFrame(), true, true);
EXPECT_TRUE(observer->IsPluginTemporarilyAllowed(foo_plugin));
EXPECT_FALSE(observer->IsPluginTemporarilyAllowed(bar_plugin));
@@ -428,7 +428,7 @@ TEST_F(ChromeRenderViewTest, ContentSettingsSamePageNavigation) {
// The page shouldn't see the change to script blocking setting after a
// same page navigation.
- DidNavigateWithinPage(GetMainFrame(), true);
+ DidNavigateWithinPage(GetMainFrame(), true, true);
EXPECT_TRUE(observer->allowScript(true));
}
« no previous file with comments | « no previous file | chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698