chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc - Issue 1976573002: Only use pending navigation params for browser-initiated navigations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

Issue 1976573002: Only use pending navigation params for browser-initiated navigations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: backward comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/content_settings_observer_browsertest.cc ('k') | content/public/test/render_view_test.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

index d4efbc3e3093bcefe7b2ee97c6f1ac195c21e452..8140c3b12d176764090e00ddf1686c7b9974dfe5 100644

--- a/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

+++ b/chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc

@@ -186,7 +186,7 @@ TEST_F(PhishingClassifierDelegateTest, Navigation) {

// Navigating within page works similarly to a subframe navigation, but

// see the TODO in PhishingClassifierDelegate::DidCommitProvisionalLoad.

EXPECT_CALL(*classifier_, CancelPendingClassification());

- DidNavigateWithinPage(GetMainFrame(), true);

+ DidNavigateWithinPage(GetMainFrame(), true, false);

Mock::VerifyAndClearExpectations(classifier_);

OnStartPhishingDetection(url);

@@ -251,7 +251,7 @@ TEST_F(PhishingClassifierDelegateTest, Navigation) {

EXPECT_CALL(*classifier_, CancelPendingClassification());

// In-page navigation.

- DidNavigateWithinPage(GetMainFrame(), true);

+ DidNavigateWithinPage(GetMainFrame(), true, false);

Charlie Reis 2016/05/12 20:51:47 Just curious, was there a reason this needed to be

Avi (use Gerrit) 2016/05/12 23:41:17 I kinda picked it arbitrarily.

Mock::VerifyAndClearExpectations(classifier_);

OnStartPhishingDetection(url);