Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1976553002: [turbofan] Properly initialize mutable heap numbers in literals. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.0
Target Ref:
refs/pending/branch-heads/5.0
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly initialize mutable heap numbers in literals. We accidently drop the effect of the initializing store on the floor and just hang on to the effect of the mutable heap number allocation. This means that the store is actually dead code and will be trimmed from the graph. R=mstarzinger@chromium.org BUG=chromium:610228 NOPRESUBMIT=true NOTRY=true LOG=n

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -30 lines) Patch
M src/compiler/js-create-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-create-lowering.cc View 2 chunks +11 lines, -19 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-610228.js View 1 chunk +4 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-12 11:55:32 UTC) #1
Michael Starzinger
LGTM.
4 years, 7 months ago (2016-05-12 11:57:16 UTC) #2
Benedikt Meurer
4 years, 7 months ago (2016-05-12 12:02:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
60a6658f20fb07082e194bec74857af6f2b7b164.

Powered by Google App Engine
This is Rietveld 408576698