Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1976543002: Version 5.2.295.1 (cherry-pick) (Closed)

Created:
4 years, 7 months ago by Michael Hablich
Modified:
4 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.2.295
Target Ref:
refs/pending/heads/5.2.295
Project:
v8
Visibility:
Public.

Description

Version 5.2.295.1 (cherry-pick) Merged 51db73923d075588d405d3d6c74a616ef302fed6 Revert of Change v8_snapshot_toolchain to be a GN build arg. (patchset #3 id:40001 of https://codereview.chromium.org/1969693002/ ) BUG=608596 LOG=N TBR=machenbach@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2dfffeaf47b69ce60781b9c8fc55a2e9133342e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -30 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot_toolchain.gni View 1 chunk +11 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Hablich
4 years, 7 months ago (2016-05-12 08:44:20 UTC) #1
Michael Hablich
Committed patchset #1 (id:1) manually as 2dfffeaf47b69ce60781b9c8fc55a2e9133342e4.
4 years, 7 months ago (2016-05-12 08:47:35 UTC) #3
Michael Achenbach
4 years, 7 months ago (2016-05-12 09:05:24 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698