Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 197653006: Media Galleries API Metadata: Add libexif to list of Linux system library deps (Closed)

Created:
6 years, 9 months ago by tommycli
Modified:
6 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Media Galleries API Metadata: Add libexif to list of Linux system library deps Adds libexif to list of system libs chromium build on Linux depends on. In service of https://codereview.chromium.org/191583002/ BUG=318450 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/install-build-deps.sh View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tommycli
This is just the libexif include in the list of system libs.
6 years, 9 months ago (2014-03-12 23:17:09 UTC) #1
Lei Zhang
LGTM Let's figure out the situation on supported Linux distros before committing this. At least ...
6 years, 9 months ago (2014-03-12 23:45:00 UTC) #2
tommycli
On 2014/03/12 23:45:00, Lei Zhang wrote: > LGTM > > Let's figure out the situation ...
6 years, 9 months ago (2014-03-13 20:15:29 UTC) #3
Lei Zhang
Sounds good. Commit away.
6 years, 9 months ago (2014-03-13 21:00:40 UTC) #4
tommycli
The CQ bit was checked by tommycli@chromium.org
6 years, 9 months ago (2014-03-13 21:01:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/197653006/1
6 years, 9 months ago (2014-03-13 21:02:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommycli@chromium.org/197653006/1
6 years, 9 months ago (2014-03-14 00:19:37 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-14 05:56:19 UTC) #8
Message was sent while issue was closed.
Change committed as 257017

Powered by Google App Engine
This is Rietveld 408576698