Move ParseAssignmentExpression to ParserBase.

Move ParseAssignmentExpression to ParserBase.

R=mstarzinger@chromium.org, mstarzinger
BUG=v8:3126
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=19908

Committed: https://code.google.com/p/v8/source/detail?r=19920

[marja, 2014-03-12 16:23:54]

rossberg, ptal

[marja, 2014-03-13 08:32:42]

(reviewer swap, mstarzinger, ptal)

[Michael Starzinger, 2014-03-13 08:52:41]

LGTM.

https://codereview.chromium.org/197653002/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/197653002/diff/1/src/preparser.h#newcode1559
src/preparser.h:1559: return this->ParseYieldExpression(ok);
As discussed offline: It would be nice to get rid of all this explicit "this->"
prefixes. But since this is on your plate as final cleanup anyways, I am fine
with it.

[rossberg, 2014-03-13 09:25:34]

https://codereview.chromium.org/197653002/diff/1/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/197653002/diff/1/src/parser.h#newcode484
src/parser.h:484: // with JSC we choose to report the error at runtime.
Do we have plans to fix this eventually? It's clearly a spec violation, and I
don't think we have to worry about JSC any longer.

https://codereview.chromium.org/197653002/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/197653002/diff/1/src/preparser.h#newcode1559
src/preparser.h:1559: return this->ParseYieldExpression(ok);
On 2014/03/13 08:52:41, Michael Starzinger wrote:
> As discussed offline: It would be nice to get rid of all this explicit
"this->"
> prefixes. But since this is on your plate as final cleanup anyways, I am fine
> with it.

FWIW, I like the explicit this->, and would prefer a style guide that requires
them, always. Makes reading and esp refactoring so much easier. Remember
handlification? :)

[marja, 2014-03-13 15:54:48]

thx for comments!

https://codereview.chromium.org/197653002/diff/1/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/197653002/diff/1/src/parser.h#newcode484
src/parser.h:484: // with JSC we choose to report the error at runtime.
On 2014/03/13 09:25:34, rossberg wrote:
> Do we have plans to fix this eventually? It's clearly a spec violation, and I
> don't think we have to worry about JSC any longer.

Wasn't on my radar (yet), but I'll put it on my TODO list. Won't some tests fail
if this is fixed?

(I'll leave fixing that out of this refactoring CL.)

[marja, 2014-03-13 16:06:15]

Committed patchset #3 manually as r19908 (presubmit successful).

[marja, 2014-03-14 09:43:12]

Committed patchset #5 manually as r19920 (presubmit successful).

[marja, 2014-03-14 09:44:40]

On 2014/03/14 09:43:12, marja wrote:
> Committed patchset #5 manually as r19920 (presubmit successful).

FYI, I'm reusing this code review for landing the version with the clang build
fix. I think this is more reasonable that creating another CL. For example, you
can see what the fix was via "delta from patch set".