third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp - Issue 1976513002: Set the request mode and the credentials mode even if the request will not go to ServiceWorker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

Issue 1976513002: Set the request mode and the credentials mode even if the request will not go to ServiceWorker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test and update coment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

diff --git a/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp b/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

index 1bbdd6d2a832e63c3a072b6530f017a3d0d2bf93..3846fe0b4eb03b765f5eec171459edbd72c0dc90 100644

--- a/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

+++ b/third_party/WebKit/Source/web/AssociatedURLLoaderTest.cpp

@@ -321,10 +321,13 @@ TEST_F(AssociatedURLLoaderTest, SameOriginRestriction)

TEST_F(AssociatedURLLoaderTest, CrossOriginSuccess)

{

// This is cross-origin since the frame was loaded from www.test.com.

- KURL url = toKURL("http://www.other.com/CrossOriginSuccess.html");

+ KURL url = toKURL("http://www.other.com/CrossOriginSuccess");

tyoshino (SeeGerritForStatus) 2016/05/16 07:12:42 What's this change for?

horo 2016/05/16 07:23:15 I think it is weird to send the Script context req

WebURLRequest request;

request.initialize();

request.setURL(url);

+ // No-CORS requests (CrossOriginRequestPolicyAllow) aren't allowed for the

+ // default context requests. So we set the context as Script here.

tyoshino (SeeGerritForStatus) 2016/05/16 07:12:42 "request" is duplicated. No-CORS is not allowed f

horo 2016/05/16 07:23:15 Done.

+ request.setRequestContext(WebURLRequest::RequestContextScript);

m_expectedResponse = WebURLResponse();

m_expectedResponse.initialize();