X87: [Interpreter] Fix incorrect frame walking in arguments create stubs.

X87: [Interpreter] Fix incorrect frame walking in arguments create stubs.

  port 40f345416f00761c79b9d2094c2e12e798329935 (r36181)

  original commit message:
  The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
  looked at the function slot in order to skip stub frames
  and find the JS frame. However, stub frames do not have a
  function slot (in fact their fixed frame ends one slot
  before the JS frame's function slot). Therefore, if this
  location in the stub frame happens to have the function
  object the create arguments stubs won't skip this frame
  correctly.

  Replace this approach with one where the stub is
  specialized to either skip a frame if required (since
  there will only ever be one extra frame on Ignition
  the loop approach isn't necessary).

BUG=

Committed: https://crrev.com/d748daa3552cd713a47294828d45865dfee064a0
Cr-Commit-Position: refs/heads/master@{#36197}

[zhengxing.li, 2016-05-12 05:46:48]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, rmcilroy@chromium.org, weiliang.lin@intel.com

[zhengxing.li, 2016-05-12 05:46:48]

PTAL, thanks!

[Weiliang, 2016-05-12 06:58:42]

lgtm

[zhengxing.li, 2016-05-12 06:59:22]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-05-12 06:59:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1976483002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1976483002/1

[commit-bot: I haz the power, 2016-05-12 07:29:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-12 07:29:30]

Description was changed from

==========
X87: [Interpreter] Fix incorrect frame walking in arguments create stubs.

  port 40f345416f00761c79b9d2094c2e12e798329935 (r36181)

  original commit message:
  The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
  looked at the function slot in order to skip stub frames
  and find the JS frame. However, stub frames do not have a
  function slot (in fact their fixed frame ends one slot
  before the JS frame's function slot). Therefore, if this
  location in the stub frame happens to have the function
  object the create arguments stubs won't skip this frame
  correctly.

  Replace this approach with one where the stub is
  specialized to either skip a frame if required (since
  there will only ever be one extra frame on Ignition
  the loop approach isn't necessary).

BUG=
==========

to

==========
X87: [Interpreter] Fix incorrect frame walking in arguments create stubs.

  port 40f345416f00761c79b9d2094c2e12e798329935 (r36181)

  original commit message:
  The previous approach taken by FastNew[Sloppy,Strict,Rest]ArgumentsStub
  looked at the function slot in order to skip stub frames
  and find the JS frame. However, stub frames do not have a
  function slot (in fact their fixed frame ends one slot
  before the JS frame's function slot). Therefore, if this
  location in the stub frame happens to have the function
  object the create arguments stubs won't skip this frame
  correctly.

  Replace this approach with one where the stub is
  specialized to either skip a frame if required (since
  there will only ever be one extra frame on Ignition
  the loop approach isn't necessary).

BUG=

Committed: https://crrev.com/d748daa3552cd713a47294828d45865dfee064a0
Cr-Commit-Position: refs/heads/master@{#36197}
==========

[commit-bot: I haz the power, 2016-05-12 07:29:31]

Patchset 1 (id:??) landed as
https://crrev.com/d748daa3552cd713a47294828d45865dfee064a0
Cr-Commit-Position: refs/heads/master@{#36197}