Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1976473003: Fixes header translation between SpdyHeaderBlock and other data structures. Not protected. (Closed)

Created:
4 years, 7 months ago by Buck
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Biren Roy
Base URL:
https://chromium.googlesource.com/chromium/src.git@121370394
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes header translation between SpdyHeaderBlock and other data structures. Not protected. In SPDY, header fields with multiple values are represented in a SpdyHeaderBlock by joining the multiple values together with a null character. This change fixes QUIC-specific utilities that work with SpdyHeaderBlocks. Merge internal change: 121373674 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -8 lines) Patch
M net/quic/spdy_utils.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M net/quic/spdy_utils_test.cc View 2 chunks +90 lines, -0 lines 0 comments Download
M net/tools/quic/spdy_balsa_utils.cc View 4 chunks +26 lines, -3 lines 0 comments Download
M net/tools/quic/spdy_balsa_utils_test.cc View 4 chunks +18 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
Buck
4 years, 7 months ago (2016-05-12 23:38:03 UTC) #1
Ryan Hamilton
lgtm
4 years, 7 months ago (2016-05-13 04:27:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976473003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976473003/1
4 years, 7 months ago (2016-05-13 20:32:06 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 21:23:05 UTC) #6
Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

Powered by Google App Engine
This is Rietveld 408576698