third_party/WebKit/Source/core/fetch/Resource.h - Issue 1976463003: Preload scan external CSS for @import

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 1976463003: Preload scan external CSS for @import (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: actually include crasher fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fetch/Resource.h

diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h

index 29792f1333b1604056b33e0d96589e105e02eed3..ea028763c7b53507904c51ba2b56e93d80b5c9ae 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.h

+++ b/third_party/WebKit/Source/core/fetch/Resource.h

@@ -126,7 +126,9 @@ public:

void didChangePriority(ResourceLoadPriority, int intraPriorityValue);

virtual ResourcePriority priorityFromObservers() { return ResourcePriority(); }

- void addClient(ResourceClient*);

+ // |passive| indicates that the client should not affect whether a preload

+ // considers itself referenced.

+ void addClient(ResourceClient*, bool passive = false);

hiroshige 2016/06/17 12:15:17 Defining and using enum instead of |bool| will be

Charlie Harrison 2016/07/13 18:18:14 Done.

void removeClient(ResourceClient*);

virtual bool hasClientsOrObservers() const { return !m_clients.isEmpty() || !m_clientsAwaitingCallback.isEmpty() || !m_finishedClients.isEmpty(); }

@@ -254,7 +256,7 @@ protected:

void finishPendingClients();

virtual void didAddClient(ResourceClient*);

- void willAddClientOrObserver();

+ void willAddClientOrObserver(bool passive = false);

hiroshige 2016/06/17 12:15:17 Please do not set default value for |passive| here

Charlie Harrison 2016/07/13 18:18:14 Done.

// |this| object may be dead after didRemoveClientOrObserver().

void didRemoveClientOrObserver();