Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1976433003: Remove dated NavigationScheduler TODO. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dated NavigationScheduler TODO. Task closures created by CancellableTaskFactory keep a weak reference back to their owning GCed object, allowing the object to be garbage collected without the task keeping it alive. Retire the TODO in the NavigationScheduler suggesting otherwise along with adding a unit test to verify the weakness property. R= BUG=585328 Committed: https://crrev.com/abf584361ba33ce3f42c5927512690a471c8ac61 Cr-Commit-Position: refs/heads/master@{#393210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -2 lines) Patch
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/CancellableTaskFactoryTest.cpp View 2 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-12 07:00:11 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-12 07:18:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976433003/1
4 years, 7 months ago (2016-05-12 08:45:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-12 08:49:17 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abf584361ba33ce3f42c5927512690a471c8ac61 Cr-Commit-Position: refs/heads/master@{#393210}
4 years, 7 months ago (2016-05-12 08:50:25 UTC) #10
alex clarke (OOO till 29th)
4 years, 7 months ago (2016-05-12 09:02:06 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698