Chromium Code Reviews| Index: chrome/browser/android/signin/signin_manager_android.h |
| diff --git a/chrome/browser/android/signin/signin_manager_android.h b/chrome/browser/android/signin/signin_manager_android.h |
| index 6a414e77280898eed78bd41fbd08eef62f4273aa..e77e9b9e1a038345956467e6a039d5ee00df47fe 100644 |
| --- a/chrome/browser/android/signin/signin_manager_android.h |
| +++ b/chrome/browser/android/signin/signin_manager_android.h |
| @@ -14,6 +14,7 @@ |
| #include "base/macros.h" |
| #include "base/memory/weak_ptr.h" |
| #include "components/prefs/pref_change_registrar.h" |
| +#include "components/signin/core/browser/signin_manager.h" |
|
maxbogue
2016/05/16 22:51:02
signin_manager_base.h, since that's the class you
Patrick Noland
2016/05/17 21:30:07
Done.
|
| class Profile; |
| @@ -29,7 +30,7 @@ class CloudPolicyClient; |
| // |
| // This class implements parts of the sign-in flow, to make sure that policy |
| // is available before sign-in completes. |
| -class SigninManagerAndroid { |
| +class SigninManagerAndroid : public SigninManagerBase::Observer { |
| public: |
| SigninManagerAndroid(JNIEnv* env, jobject obj); |
| @@ -76,8 +77,17 @@ class SigninManagerAndroid { |
| jboolean IsSignedInOnNative(JNIEnv* env, |
| const base::android::JavaParamRef<jobject>& obj); |
| + void GoogleSigninFailed(const GoogleServiceAuthError& error) override; |
|
maxbogue
2016/05/16 22:51:02
For implementations of interfaces, put a comment l
Patrick Noland
2016/05/17 21:30:07
Done.
|
| + |
| + void GoogleSigninSucceeded(const std::string& account_id, |
| + const std::string& username, |
| + const std::string& password) override; |
| + |
| + void GoogleSignedOut(const std::string& account_id, |
| + const std::string& username) override; |
| + |
| private: |
| - ~SigninManagerAndroid(); |
| + ~SigninManagerAndroid() override; |
| void OnPolicyRegisterDone(const std::string& dm_token, |
| const std::string& client_id); |