enable top-level @JS() getters

enable top-level @JS() getters

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/8ea44215ce0917e6f9d8ce7e97063acc77a87dce

[Harry Terkelsen, 2016-05-13 22:52:30]

het@google.com changed reviewers:
+ jacobr@google.com, jmesserly@google.com

[Jennifer Messerly, 2016-05-13 23:19:17]

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2333: return new JS.PropertyAccess(new
JS.Identifier('self'), name);
Where is "self" coming from?

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2552: if (typeArgs != null) {
just curious about the reason for this change?

Overall I think it's a good idea :) -- the "dynamic call to a static target"
case was a bit flaky. But just curious what particular case you hit.

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2553: return js.call('dart.dgsend(#, #, #,
#)',
this code looks copy+pasted, can we share it with _emitMethodCall somehow?

[Harry Terkelsen, 2016-05-13 23:34:43]

thanks John, ptal

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2333: return new JS.PropertyAccess(new
JS.Identifier('self'), name);
On 2016/05/13 23:19:17, John Messerly wrote:
> Where is "self" coming from?

hmm, I've mostly been doing it because dart2js uses self. It is working with the
tests because 'window.self = this' but we'd probably run into issues if someone
set 'self' in a method. Is there a DDC way to refer to the 'window' object in a
way that will never get overwritten?

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2552: if (typeArgs != null) {
On 2016/05/13 23:19:16, John Messerly wrote:
> just curious about the reason for this change?
> 
> Overall I think it's a good idea :) -- the "dynamic call to a static target"
> case was a bit flaky. But just curious what particular case you hit.

Basically because of this line:
https://github.com/dart-lang/dev_compiler/blob/master/test/codegen/lib/html/j...

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2553: return js.call('dart.dgsend(#, #, #,
#)',
On 2016/05/13 23:19:17, John Messerly wrote:
> this code looks copy+pasted, can we share it with _emitMethodCall somehow?

I merged it with the above

[Jennifer Messerly, 2016-05-13 23:51:07]

LGTM

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2333: return new JS.PropertyAccess(new
JS.Identifier('self'), name);
On 2016/05/13 23:34:43, Harry Terkelsen wrote:
> On 2016/05/13 23:19:17, John Messerly wrote:
> > Where is "self" coming from?
> 
> hmm, I've mostly been doing it because dart2js uses self. It is working with
the
> tests because 'window.self = this' but we'd probably run into issues if
someone
> set 'self' in a method. Is there a DDC way to refer to the 'window' object in
a
> way that will never get overwritten?

Hmmmmm ... I don't think we have a reliable way to reach "window". Using "this"
at the top level scope should do it. You could inject a temporary: `const self =
this;` at the module level to provide access.
http://www.ecma-international.org/ecma-262/6.0/#sec-global-environment-records

(That said I'm not 100% sure if our ES5 module transform won't mess that pattern
up, but conceptually I think it works :) )

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2552: if (typeArgs != null) {
On 2016/05/13 23:34:43, Harry Terkelsen wrote:
> On 2016/05/13 23:19:16, John Messerly wrote:
> > just curious about the reason for this change?
> > 
> > Overall I think it's a good idea :) -- the "dynamic call to a static target"
> > case was a bit flaky. But just curious what particular case you hit.
> 
> Basically because of this line:
>
https://github.com/dart-lang/dev_compiler/blob/master/test/codegen/lib/html/j...

Thanks, makes sense :)

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2553: return js.call('dart.dgsend(#, #, #,
#)',
On 2016/05/13 23:34:43, Harry Terkelsen wrote:
> On 2016/05/13 23:19:17, John Messerly wrote:
> > this code looks copy+pasted, can we share it with _emitMethodCall somehow?
> 
> I merged it with the above

Looks great :)

[Harry Terkelsen, 2016-05-16 16:18:14]

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
File lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/1976383002/diff/20001/lib/src/compiler/code_g...
lib/src/compiler/code_generator.dart:2333: return new JS.PropertyAccess(new
JS.Identifier('self'), name);
On 2016/05/13 23:51:07, John Messerly wrote:
> On 2016/05/13 23:34:43, Harry Terkelsen wrote:
> > On 2016/05/13 23:19:17, John Messerly wrote:
> > > Where is "self" coming from?
> > 
> > hmm, I've mostly been doing it because dart2js uses self. It is working with
> the
> > tests because 'window.self = this' but we'd probably run into issues if
> someone
> > set 'self' in a method. Is there a DDC way to refer to the 'window' object
in
> a
> > way that will never get overwritten?
> 
> Hmmmmm ... I don't think we have a reliable way to reach "window". Using
"this"
> at the top level scope should do it. You could inject a temporary: `const self
=
> this;` at the module level to provide access.
> http://www.ecma-international.org/ecma-262/6.0/#sec-global-environment-records
> 
> (That said I'm not 100% sure if our ES5 module transform won't mess that
pattern
> up, but conceptually I think it works :) )

Done.

[Harry Terkelsen, 2016-05-16 16:22:36]

Description was changed from

==========
enable top-level @JS() getters

BUG=
==========

to

==========
enable top-level @JS() getters

BUG=
R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/8ea44215ce0917e6f9d8ce7e9706...
==========

[Harry Terkelsen, 2016-05-16 16:22:37]

Committed patchset #5 (id:80001) manually as
8ea44215ce0917e6f9d8ce7e97063acc77a87dce (presubmit successful).