Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1976333002:
mac/gn: Make remaining targets link in release component builds (Closed)
|
Created:
4 years, 7 months ago by Nico Modified:
4 years, 7 months ago CC:
chromium-reviews, imcheng+watch_chromium.org, chromoting-reviews_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionmac/gn: Make remaining targets link in release component builds
BUG=431177
TBR=sergeyu
Committed: https://crrev.com/4376c8aa4453d759aeb9cafbe3afe54e3f620f55
Cr-Commit-Position: refs/heads/master@{#393739}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : . #
Messages
Total messages: 27 (13 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976333002/1
thakis@chromium.org changed reviewers: + miu@chromium.org, rsesek@chromium.org
miu: media/cast. Not ethat the two static_libraries did nothing before -- source_set deps are only pulled in if is_complete_lib is set.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
LGTM
media/cast lgtm. Thanks! I was looking for that. FWIW, there is a project in our queue to better handle the build/linkage for this code so that source_set() is used for Chromium builds, but static_library() for distributable, minimized object code for linking into external projects.
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org, miu@chromium.org Link to the patchset: https://codereview.chromium.org/1976333002/#ps40001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976333002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== mac/gn: Make remaining targets link in release component builds BUG=431177 ========== to ========== mac/gn: Make remaining targets link in release component builds BUG=431177 TBR=sergeyu ==========
thakis@chromium.org changed reviewers: + sergeyu@chromium.org
tbr sergeyu for remoting comment changes
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976333002/40001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976333002/40001
Message was sent while issue was closed.
Description was changed from ========== mac/gn: Make remaining targets link in release component builds BUG=431177 TBR=sergeyu ========== to ========== mac/gn: Make remaining targets link in release component builds BUG=431177 TBR=sergeyu ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== mac/gn: Make remaining targets link in release component builds BUG=431177 TBR=sergeyu ========== to ========== mac/gn: Make remaining targets link in release component builds BUG=431177 TBR=sergeyu Committed: https://crrev.com/4376c8aa4453d759aeb9cafbe3afe54e3f620f55 Cr-Commit-Position: refs/heads/master@{#393739} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4376c8aa4453d759aeb9cafbe3afe54e3f620f55 Cr-Commit-Position: refs/heads/master@{#393739} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
