Issue 197633002: Fix dashed/dotted regression caused by multi-style text decoration patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197633002: Fix dashed/dotted regression caused by multi-style text decoration patch. (Closed)

Created:
6 years, 9 months ago by andersr

Modified:
6 years, 9 months ago

Reviewers:
Stephen Chennney

CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fix dashed/dotted regression caused by multi-style text decoration patch. If you fall through from TextDecorationStyle[Dotted, Dashed] to TextDecorationStyleDouble, then obviously double lines will be drawn. Also, change code to reuse as much code as possible rather than duplicate approximately the same thing three times. There should be no functional changes other than the regression fix. BUG=351282 TEST=Covered by existing tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169039