Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 197633002: Fix dashed/dotted regression caused by multi-style text decoration patch. (Closed)

Created:
6 years, 9 months ago by andersr
Modified:
6 years, 9 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix dashed/dotted regression caused by multi-style text decoration patch. If you fall through from TextDecorationStyle[Dotted, Dashed] to TextDecorationStyleDouble, then obviously double lines will be drawn. Also, change code to reuse as much code as possible rather than duplicate approximately the same thing three times. There should be no functional changes other than the regression fix. BUG=351282 TEST=Covered by existing tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -58 lines) Patch
M Source/core/rendering/InlineTextBox.cpp View 3 chunks +27 lines, -58 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
andersr
6 years, 9 months ago (2014-03-12 16:13:09 UTC) #1
Stephen Chennney
lgtm
6 years, 9 months ago (2014-03-12 16:30:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/197633002/1
6 years, 9 months ago (2014-03-12 16:30:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/197633002/1
6 years, 9 months ago (2014-03-12 16:49:33 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 17:33:58 UTC) #5
Message was sent while issue was closed.
Change committed as 169039

Powered by Google App Engine
This is Rietveld 408576698