src/x64/assembler-x64-inl.h - Issue 19763010: Use kPointerSize to compute the call instruction offset in the PatchedReturnSequence for X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64-inl.h

Issue 19763010: Use kPointerSize to compute the call instruction offset in the PatchedReturnSequence for X64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64-inl.h

diff --git a/src/x64/assembler-x64-inl.h b/src/x64/assembler-x64-inl.h

index 1c231a70b62b5395d6b37bc333b751f2f7d98cdd..b9af527eea33b1fabb3ee50fa80abc2ca09eae60 100644

--- a/src/x64/assembler-x64-inl.h

+++ b/src/x64/assembler-x64-inl.h

@@ -369,7 +369,7 @@ bool RelocInfo::IsPatchedReturnSequence() {

// The 11th byte is int3 (0xCC) in the return sequence and

// REX.WB (0x48+register bit) for the call sequence.

#ifdef ENABLE_DEBUGGER_SUPPORT

- return pc_[10] != 0xCC;

+ return pc_[2 + kPointerSize] != 0xCC;

#else

return false;

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »