chrome/common/extensions/docs/templates/intros/location.html - Issue 19763008: Adding dev documentation for chrome.location

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/docs/templates/intros/location.html

Issue 19763008: Adding dev documentation for chrome.location (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/common/extensions/api/location.idl ('K') | « chrome/common/extensions/api/location.idl ('k') | chrome/common/extensions/docs/templates/public/apps/location.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <p id="classSummary">
	Jeffrey Yasskin 2013/07/27 03:00:29 Does this id do anything visible in the UI? Would Does this id do anything visible in the UI? Would it make more sense to head this section with an <h2 id="classSummary"> (or "overview" like some other APIs)? vadimt 2013/07/30 01:58:41 Done. Show quoted text On 2013/07/27 03:00:29, Jeffrey Yasskin wrote: > Does this id do anything visible in the UI? Would it make more sense to head > this section with an <h2 id="classSummary"> (or "overview" like some other > APIs)? Done.
	2 To create a location watch, call $ref:location.watchLocation passing in
	Andy 2013/07/30 00:56:06 Before you explain how to create a location watch, Before you explain how to create a location watch, it would be helpful to provide a little context: What is a location watch and when would you use one? vadimt 2013/07/30 01:58:41 Done. Show quoted text On 2013/07/30 00:56:06, Andy wrote: > Before you explain how to create a location watch, it would be helpful to > provide a little context: What is a location watch and when would you use one? Done.
	3 the location watch details via the <code>requestInfo</code> parameter:

	4 </p>

	5

	6 <pre>chrome.location.watchLocation(name, requestInfo);</pre>

	7 <p>

	8 You'll also need to add a listener
	Andy 2013/07/30 00:56:06 Suggestion: "You'll also" --> "You also" Suggestion: "You'll also" --> "You also" vadimt 2013/07/30 01:58:41 Done. Show quoted text On 2013/07/30 00:56:06, Andy wrote: > Suggestion: "You'll also" --> "You also" Done.
	9 to its <code>onChanged</code> event.
	Andy 2013/07/30 00:56:06 What does "its" refer to here? What does "its" refer to here? vadimt 2013/07/30 01:58:41 Done. Show quoted text On 2013/07/30 00:56:06, Andy wrote: > What does "its" refer to here? Done.
	10 Chrome will fire this event after you create your location watch. After this,

	11 it will keep firing the event every time the geographical location of your

	12 computer changes until you call $ref:location.clearWatch.
	Andy 2013/07/30 00:56:06 Suggestion: "the geographical location of your com Suggestion: "the geographical location of your computer" --> "the geographic location of the host machine" vadimt 2013/07/30 01:58:41 Done. Show quoted text On 2013/07/30 00:56:06, Andy wrote: > Suggestion: "the geographical location of your computer" --> "the geographic > location of the host machine" Done.
	13 </p>

	14 <p>

	15 Here's sample code

	16 to listen for location updates:

	17 </p>

	18 <pre>

	19 chrome.location.onLocationUpdate.addListener(function(position) {

	20 console.log(JSON.stringify(position));

	21 });

	22 </pre>

OLD	NEW