Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1976283002: Revert of DevTools: blur previous element when focus changes (Closed)

Created:
4 years, 7 months ago by luoe
Modified:
4 years, 7 months ago
Reviewers:
dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of DevTools: blur previous element when focus changes (patchset #2 id:20001 of https://codereview.chromium.org/1950343003/ ) Reason for revert: This patchset breaks the ability to hide the color picker popover in some cases. See https://bugs.chromium.org/p/chromium/issues/detail?id=611803 Reverting will break the original bug, affecting focus in the full text search drawer. Original issue's description: > DevTools: blur previous element when focus changes > > BUG=609013 > > Committed: https://crrev.com/afe5fb69c6324250594694f76e87b2de824e49e2 > Cr-Commit-Position: refs/heads/master@{#392489} TBR=lushnikov@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=609013 Committed: https://crrev.com/09713de62a12f9245c2e54f5fab88eadb1c63dfd Cr-Commit-Position: refs/heads/master@{#393775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
luoe
Created Revert of DevTools: blur previous element when focus changes
4 years, 7 months ago (2016-05-13 20:34:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976283002/1
4 years, 7 months ago (2016-05-13 20:34:51 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-13 20:34:53 UTC) #4
dgozman
lgtm
4 years, 7 months ago (2016-05-15 17:56:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976283002/1
4 years, 7 months ago (2016-05-15 17:56:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-15 19:29:13 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-15 19:30:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09713de62a12f9245c2e54f5fab88eadb1c63dfd
Cr-Commit-Position: refs/heads/master@{#393775}

Powered by Google App Engine
This is Rietveld 408576698