Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1976263003: [ios] Allow using ipc on iOS via GN. (Closed)

Created:
4 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Allow using ipc on iOS via GN. GYP supports ipc for iOS. IPC is used in Mojo and iOS will support Mojo for WebUI. BUG=611843 Committed: https://crrev.com/c5e032910d4c8119f8c40df507fda64e5fec11a0 Cr-Commit-Position: refs/heads/master@{#393651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ipc/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Eugene But (OOO till 7-30)
4 years, 7 months ago (2016-05-13 20:02:33 UTC) #2
Tom Sepez
OWNERS LGTM
4 years, 7 months ago (2016-05-13 20:07:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976263003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976263003/1
4 years, 7 months ago (2016-05-13 20:20:18 UTC) #5
Eugene But (OOO till 7-30)
Thank you for quick review!
4 years, 7 months ago (2016-05-13 20:20:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 21:48:17 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 21:50:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c5e032910d4c8119f8c40df507fda64e5fec11a0
Cr-Commit-Position: refs/heads/master@{#393651}

Powered by Google App Engine
This is Rietveld 408576698