Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 197623005: Rename PPB_Find_Dev to PPB_Find_Private (Closed)

Created:
6 years, 9 months ago by raymes
Modified:
6 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, yusukes+watch_chromium.org, tzik, raymes+watch_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, Sam Clegg, nfullagar1, piman+watch_chromium.org, noelallen1, jar (doing other things), binji, ihf+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Rename PPB_Find_Dev to PPB_Find_Private This makes PPB_Find_Dev a private API and renames it as such. There is no intention to make this a public API. BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259497

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -549 lines) Patch
M chrome/browser/component_updater/ppapi_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/pepper/plugin_module.cc View 2 chunks +1 line, -1 line 0 comments Download
D content/renderer/pepper/ppp_pdf.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi/library.dsc View 2 chunks +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/libraries/ppapi_cpp/library.dsc View 2 chunks +0 lines, -2 lines 0 comments Download
D ppapi/api/dev/ppb_find_dev.idl View 1 chunk +0 lines, -56 lines 0 comments Download
D ppapi/api/dev/ppp_find_dev.idl View 1 1 chunk +0 lines, -38 lines 0 comments Download
A + ppapi/api/private/ppb_find_private.idl View 2 chunks +5 lines, -4 lines 0 comments Download
A + ppapi/api/private/ppp_find_private.idl View 1 1 chunk +1 line, -4 lines 0 comments Download
D ppapi/c/dev/ppb_find_dev.h View 1 chunk +0 lines, -70 lines 0 comments Download
D ppapi/c/dev/ppp_find_dev.h View 1 1 chunk +0 lines, -61 lines 0 comments Download
A + ppapi/c/private/ppb_find_private.h View 3 chunks +12 lines, -11 lines 0 comments Download
A + ppapi/c/private/ppp_find_private.h View 1 3 chunks +8 lines, -11 lines 0 comments Download
D ppapi/cpp/dev/find_dev.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ppapi/cpp/dev/find_dev.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M ppapi/cpp/dev/printing_dev.h View 1 chunk +1 line, -1 line 0 comments Download
A + ppapi/cpp/private/find_private.h View 4 chunks +11 lines, -11 lines 0 comments Download
A + ppapi/cpp/private/find_private.cc View 5 chunks +22 lines, -20 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_sources.gypi View 6 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_find_proxy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppp_find_proxy.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ppapi/shared_impl/api_id.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/all_c_includes.h View 4 chunks +2 lines, -2 lines 0 comments Download
M ppapi/tests/all_cpp_includes.h View 2 chunks +1 line, -1 line 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/thunk/ppb_find_dev_thunk.cc View 1 chunk +0 lines, -57 lines 0 comments Download
A + ppapi/thunk/ppb_find_private_thunk.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
raymes
6 years, 9 months ago (2014-03-13 02:47:23 UTC) #1
Alexei Svitkine (slow)
https://codereview.chromium.org/197623005/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/197623005/diff/1/tools/metrics/histograms/histograms.xml#oldcode32236 tools/metrics/histograms/histograms.xml:32236: - <int value="2012645499" label="PPB_Find(Dev);0.3"/> Please keep this entry, so ...
6 years, 9 months ago (2014-03-13 13:42:25 UTC) #2
raymes
Thanks, I'll make that change. -yzshen, +teravest
6 years, 9 months ago (2014-03-13 23:41:58 UTC) #3
teravest
lgtm lgtm https://codereview.chromium.org/197623005/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/197623005/diff/1/tools/metrics/histograms/histograms.xml#oldcode32236 tools/metrics/histograms/histograms.xml:32236: - <int value="2012645499" label="PPB_Find(Dev);0.3"/> You should keep ...
6 years, 9 months ago (2014-03-19 14:21:43 UTC) #4
Alexei Svitkine (slow)
LGTM but please don't land without addressing the comment. https://codereview.chromium.org/197623005/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/197623005/diff/1/tools/metrics/histograms/histograms.xml#oldcode32236 tools/metrics/histograms/histograms.xml:32236: ...
6 years, 9 months ago (2014-03-19 18:50:48 UTC) #5
raymes
https://codereview.chromium.org/197623005/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/197623005/diff/1/tools/metrics/histograms/histograms.xml#oldcode32236 tools/metrics/histograms/histograms.xml:32236: - <int value="2012645499" label="PPB_Find(Dev);0.3"/> On 2014/03/19 18:50:49, Alexei Svitkine ...
6 years, 9 months ago (2014-03-20 01:05:45 UTC) #6
raymes
+noelallen for native_client_sdk/*
6 years, 9 months ago (2014-03-20 01:21:13 UTC) #7
raymes
On 2014/03/20 01:21:13, raymes wrote: > +noelallen for native_client_sdk/* Ping
6 years, 9 months ago (2014-03-24 04:20:04 UTC) #8
binji
native_client_sdk lgtm
6 years, 9 months ago (2014-03-24 15:17:16 UTC) #9
noelallen1
lgtm
6 years, 9 months ago (2014-03-24 23:36:21 UTC) #10
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 9 months ago (2014-03-26 01:04:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/197623005/40001
6 years, 9 months ago (2014-03-26 01:05:08 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 05:03:45 UTC) #13
Message was sent while issue was closed. 
Change committed as 259497

Powered by Google App Engine
This is Rietveld 408576698