Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 1976213002: Adjusts dart2js backend to handle method type arguments. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Made MethodTypeVariableType malformed, eliminated malformMethodTypeVariableType Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 15b8de496ee7a89c6107e068974543cdded93b45..bd59c2d575d2d399d525057c422d6bc91df7a974 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -2738,7 +2738,12 @@ class JavaScriptImpactTransformer extends ImpactTransformer {
if (type.isTypedef) {
backend.compiler.world.allTypedefs.add(type.element);
}
- if (type.isTypeVariable) {
+ if (type.isTypeVariable && type is! MethodTypeVariableType) {
+ // GENERIC_METHODS: The `is!` test above filters away method type
+ // variables, because they have the value `dynamic` with the
+ // incomplete support for generic methods offered with
+ // '--generic-method-syntax'. This must be revised in order to
+ // support generic methods fully.
ClassElement cls = type.element.enclosingClass;
backend.rti.registerClassUsingTypeVariableExpression(cls);
registerBackendImpact(transformed, impacts.typeVariableExpression);

Powered by Google App Engine
This is Rietveld 408576698