pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart - Issue 1976213002: Adjusts dart2js backend to handle method type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart

Issue 1976213002: Adjusts dart2js backend to handle method type arguments. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Made MethodTypeVariableType malformed, eliminated malformMethodTypeVariableType Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/compile_time_constants.dart ('K') | « pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart ('k') | pkg/compiler/lib/src/dart_types.dart » ('j') | pkg/compiler/lib/src/dart_types.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart

diff --git a/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart b/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart

index 03f0ba1f9735b059d0a33c903c13d3294e543501..469858d0d96e36c16871b0cf6b2a647e83d6f27e 100644

--- a/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart

+++ b/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart

@@ -495,7 +495,8 @@ class TreePrinter {

: makeFunctionBody(exp.body);

result = new tree.FunctionExpression(

constructorName(exp),

- // TODO(eernst): retrieve and pass the actual type variables.

+ // GENERIC_METHODS: In order to support generic methods fully,

+ // we must retrieve and pass the actual type variables here.

null, // typeVariables

parameters,

body,

@@ -516,7 +517,8 @@ class TreePrinter {

tree.Node body = makeFunctionBody(exp.body);

result = new tree.FunctionExpression(

functionName(exp),

- // TODO(eernst): retrieve and pass the actual type variables.

+ // GENERIC_METHODS: In order to support generic methods fully,

+ // we must retrieve and pass the actual type variables here.

null, // typeVariables

parameters,

body,

@@ -802,7 +804,8 @@ class TreePrinter {

} else if (stmt is FunctionDeclaration) {

tree.FunctionExpression function = new tree.FunctionExpression(

stmt.name != null ? makeIdentifier(stmt.name) : null,

- // TODO(eernst): retrieve and pass the actual type variables.

+ // GENERIC_METHODS: In order to support generic methods fully,

+ // we must retrieve and pass the actual type variables here.

null, // typeVariables

makeParameters(stmt.parameters),

makeFunctionBody(stmt.body),

@@ -971,7 +974,8 @@ class TreePrinter {

if (param.isFunction) {

tree.Node definition = new tree.FunctionExpression(

makeIdentifier(param.name),

- // TODO(eernst): retrieve and pass the actual type variables.

+ // GENERIC_METHODS: In order to support generic methods fully,

+ // we must retrieve and pass the actual type variables here.

null, // typeVariables

makeParameters(param.parameters),

null, // body