Chromium Code Reviews| Index: pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart |
| diff --git a/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart b/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart |
| index 03f0ba1f9735b059d0a33c903c13d3294e543501..469858d0d96e36c16871b0cf6b2a647e83d6f27e 100644 |
| --- a/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart |
| +++ b/pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart |
| @@ -495,7 +495,8 @@ class TreePrinter { |
| : makeFunctionBody(exp.body); |
| result = new tree.FunctionExpression( |
| constructorName(exp), |
| - // TODO(eernst): retrieve and pass the actual type variables. |
| + // GENERIC_METHODS: In order to support generic methods fully, |
|
karlklose
2016/05/18 06:40:59
Or consider filing a bug and change this to TODO(<
eernst
2016/05/23 14:30:23
(This topic was discussed and finalized outside th
|
| + // we must retrieve and pass the actual type variables here. |
| null, // typeVariables |
| parameters, |
| body, |
| @@ -516,7 +517,8 @@ class TreePrinter { |
| tree.Node body = makeFunctionBody(exp.body); |
| result = new tree.FunctionExpression( |
| functionName(exp), |
| - // TODO(eernst): retrieve and pass the actual type variables. |
| + // GENERIC_METHODS: In order to support generic methods fully, |
| + // we must retrieve and pass the actual type variables here. |
| null, // typeVariables |
| parameters, |
| body, |
| @@ -802,7 +804,8 @@ class TreePrinter { |
| } else if (stmt is FunctionDeclaration) { |
| tree.FunctionExpression function = new tree.FunctionExpression( |
| stmt.name != null ? makeIdentifier(stmt.name) : null, |
| - // TODO(eernst): retrieve and pass the actual type variables. |
| + // GENERIC_METHODS: In order to support generic methods fully, |
| + // we must retrieve and pass the actual type variables here. |
| null, // typeVariables |
| makeParameters(stmt.parameters), |
| makeFunctionBody(stmt.body), |
| @@ -971,7 +974,8 @@ class TreePrinter { |
| if (param.isFunction) { |
| tree.Node definition = new tree.FunctionExpression( |
| makeIdentifier(param.name), |
| - // TODO(eernst): retrieve and pass the actual type variables. |
| + // GENERIC_METHODS: In order to support generic methods fully, |
| + // we must retrieve and pass the actual type variables here. |
| null, // typeVariables |
| makeParameters(param.parameters), |
| null, // body |