Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: Source/core/html/parser/HTMLDocumentParser.cpp

Issue 19762002: [HTML Imports] Let script of imported document running. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated to ToT Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/parser/HTMLDocumentParser.cpp
diff --git a/Source/core/html/parser/HTMLDocumentParser.cpp b/Source/core/html/parser/HTMLDocumentParser.cpp
index 50a998529b7271e13c785fd747a5cba24a9d7883..2df7fcdf850afd81fa9de987a79544e40d5db5d0 100644
--- a/Source/core/html/parser/HTMLDocumentParser.cpp
+++ b/Source/core/html/parser/HTMLDocumentParser.cpp
@@ -461,7 +461,9 @@ void HTMLDocumentParser::pumpPendingSpeculations()
while (!m_speculations.isEmpty()) {
processParsedChunkFromBackgroundParser(m_speculations.takeFirst());
- if (isWaitingForScripts() || isStopped())
+ // The order matters! If this isStopped(), isWaitingForScripts() can hit and ASSERT since
+ // m_document can be null which is used to decide the readiness.
+ if (isStopped() || isWaitingForScripts())
abarth-chromium 2013/07/26 17:17:34 Can you fix the instance on line 274 as well? The
break;
if (currentTime() - startTime > parserTimeLimit && !m_speculations.isEmpty()) {

Powered by Google App Engine
This is Rietveld 408576698