Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: chrome/browser/android/offline_pages/test_offline_page_model_builder.cc

Issue 1976163004: [Offline Pages] Adds Rappor metrics measuring what domains are saved & viewed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-store
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/test_offline_page_model_builder.cc
diff --git a/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc b/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc
index b8e10fd2468439b42d0e67f67423cb9236f5e1c2..abe2e46b4f3f601c369f1f0c3e17f4237001a891 100644
--- a/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc
+++ b/chrome/browser/android/offline_pages/test_offline_page_model_builder.cc
@@ -7,6 +7,7 @@
#include <utility>
#include "base/memory/ref_counted.h"
+#include "base/memory/weak_ptr.h"
#include "base/single_thread_task_runner.h"
#include "base/thread_task_runner_handle.h"
#include "chrome/common/chrome_constants.h"
@@ -14,6 +15,10 @@
#include "components/offline_pages/offline_page_test_store.h"
#include "content/public/browser/browser_context.h"
+namespace rappor {
+class RapporService;
fgorski 2016/05/13 17:49:17 this is a .cc file. Why do you forward declare thi
+}
+
namespace offline_pages {
std::unique_ptr<KeyedService> BuildTestOfflinePageModel(
@@ -28,7 +33,8 @@ std::unique_ptr<KeyedService> BuildTestOfflinePageModel(
context->GetPath().Append(chrome::kOfflinePageArchviesDirname);
return std::unique_ptr<KeyedService>(new OfflinePageModel(
- std::move(metadata_store), archives_dir, task_runner));
+ std::move(metadata_store), archives_dir,
+ base::WeakPtr<rappor::RapporService>(), task_runner));
}
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698