[Offline Pages] Adds Rappor metrics measuring what domains are saved & viewed.

[Offline Pages] Adds Rappor metrics measuring what domains are saved & viewed.

This information will be used to seed test datasets as we
try to improve the offline pages storage format.

LOW_FREQUENCY metrics are used because we expect to initially
serve a small population.  Once broad release is achieved,
this could be switched to normal-noise metrics.

BUG=610877

[dewittj, 2016-05-13 17:22:27]

Patchset #1 (id:1) has been deleted

[dewittj, 2016-05-13 17:23:39]

Description was changed from

==========
[Offline Pages] Adds Rappor metrics measuring what domains are saved & viewed.

BUG=
==========

to

==========
[Offline Pages] Adds Rappor metrics measuring what domains are saved & viewed.

LOW_FREQUENCY metrics are used because we expect to initially serve a small
population.  Once broad release is achieved, this could be switched to
normal-noise metrics.

BUG=610877
==========

[dewittj, 2016-05-13 17:25:20]

Description was changed from

==========
[Offline Pages] Adds Rappor metrics measuring what domains are saved & viewed.

LOW_FREQUENCY metrics are used because we expect to initially serve a small
population.  Once broad release is achieved, this could be switched to
normal-noise metrics.

BUG=610877
==========

to

==========
[Offline Pages] Adds Rappor metrics measuring what domains are saved & viewed.

LOW_FREQUENCY metrics are used because we expect to initially
serve a small population.  Once broad release is achieved,
this could be switched to normal-noise metrics.

BUG=610877
==========

[dewittj, 2016-05-13 17:33:45]

Description was changed from

==========
[Offline Pages] Adds Rappor metrics measuring what domains are saved & viewed.

LOW_FREQUENCY metrics are used because we expect to initially
serve a small population.  Once broad release is achieved,
this could be switched to normal-noise metrics.

BUG=610877
==========

to

==========
[Offline Pages] Adds Rappor metrics measuring what domains are saved & viewed.

This information will be used to seed test datasets as we
try to improve the offline pages storage format.

LOW_FREQUENCY metrics are used because we expect to initially
serve a small population.  Once broad release is achieved,
this could be switched to normal-noise metrics.

BUG=610877
==========

[dewittj, 2016-05-13 17:33:45]

dewittj@chromium.org changed reviewers:
+ asvitkine@chromium.org, fgorski@chromium.org, holte@chromium.org

[dewittj, 2016-05-13 17:33:58]

dewittj@chromium.org changed reviewers:
- asvitkine@chromium.org, holte@chromium.org

[dewittj, 2016-05-13 17:34:13]

fgorski: PTAL, let me know what you think of this idea.

[fgorski, 2016-05-13 17:49:18]

Idea is great :)

Did you document it in the UMA doc?

https://codereview.chromium.org/1976163004/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/test_offline_page_model_builder.cc
(right):

https://codereview.chromium.org/1976163004/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/test_offline_page_model_builder.cc:19:
class RapporService;
this is a .cc file. Why do you forward declare this thing?

https://codereview.chromium.org/1976163004/diff/20001/components/offline_page...
File components/offline_pages/offline_page_model.cc (right):

https://codereview.chromium.org/1976163004/diff/20001/components/offline_page...
components/offline_pages/offline_page_model.cc:14: #include
"base/memory/weak_ptr.h"
this is already in .h file.

https://codereview.chromium.org/1976163004/diff/20001/tools/metrics/rappor/ra...
File tools/metrics/rappor/rappor.xml (right):

https://codereview.chromium.org/1976163004/diff/20001/tools/metrics/rappor/ra...
tools/metrics/rappor/rappor.xml:1021: <rappor-metric
name="OfflinePages.ViewedPage"
could this name say that that we are viewing offline page?