|
|
Created:
6 years, 9 months ago by petarj Modified:
6 years, 9 months ago CC:
chromium-reviews, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, plundblad+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org Base URL:
http://git.chromium.org/chromium/src.git@master Visibility:
Public. |
Description[MIPS] Define liblouis_nacl nexe for MIPS
Add missing case for MIPS in liblouis_nacl_wrapper_nacl.
BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275
TEST= Chromium buildbots
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256639
Patch Set 1 #
Messages
Total messages: 15 (0 generated)
PTAL.
I don't think this is required for general NaCl MIPS support, but I could be wrong. In any case, I'm not a good reviewer. Adding somebody from the OWNERS file for that directory.
On 2014/03/12 16:37:58, dmichael wrote: > I don't think this is required for general NaCl MIPS support, but I could be > wrong. If you are referring to the bug issue I put in the commit message, you are correct, it is not required for general NaCl MIPS support, I just found the issue convenient to use in this case (since it is an umbrella issue for various related patches). > In any case, I'm not a good reviewer. Adding somebody from the OWNERS > file for that directory. Thanks. I added you as a reviewer, since you have put 'lgtm' to the last (minor) change to this file.
This would only be needed if we plan to support chromevox spoken and braille feedback for visually impaired users) on mips architectures. Thanks, //Peter To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
petarj@mips.com writes: > > In any case, I'm not a good reviewer. Adding somebody from the OWNERS > > file for that directory. > > Thanks. I added you as a reviewer, since you have put 'lgtm' to the last > (minor) change to this file. > See my previous comment. I'll lgtm this if there's a need for it. //Peter To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2014/03/12 16:59:47, Peter Lundblad wrote: > mailto:petarj@mips.com writes: > > > In any case, I'm not a good reviewer. Adding somebody from the OWNERS > > > file for that directory. > > > > Thanks. I added you as a reviewer, since you have put 'lgtm' to the last > > (minor) change to this file. > > > See my previous comment. I'll lgtm this if there's a need for it. > Truthfully, it is not required today. It will be required soon along with MIPS Chromium OS builds. I am fine with closing the issue and resubmitting it when needed, if that's what you would prefer.
lgtm I'm fine with this being added if it is going to be needed down the road anyways. Thanks, //Peter -- To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by petarj@mips.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/197613002/1
The CQ bit was unchecked by commit-bot@chromium.org
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/197613002/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/197613002/1
Message was sent while issue was closed.
Change committed as 256639 |