Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 197613002: [MIPS] Define liblouis_nacl nexe for MIPS (Closed)

Created:
6 years, 9 months ago by petarj
Modified:
6 years, 9 months ago
CC:
chromium-reviews, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, plundblad+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[MIPS] Define liblouis_nacl nexe for MIPS Add missing case for MIPS in liblouis_nacl_wrapper_nacl. BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 TEST= Chromium buildbots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/liblouis/liblouis_nacl.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
petarj
PTAL.
6 years, 9 months ago (2014-03-12 15:56:32 UTC) #1
dmichael (off chromium)
I don't think this is required for general NaCl MIPS support, but I could be ...
6 years, 9 months ago (2014-03-12 16:37:58 UTC) #2
petarj
On 2014/03/12 16:37:58, dmichael wrote: > I don't think this is required for general NaCl ...
6 years, 9 months ago (2014-03-12 16:53:05 UTC) #3
Peter Lundblad
This would only be needed if we plan to support chromevox spoken and braille feedback ...
6 years, 9 months ago (2014-03-12 16:54:00 UTC) #4
Peter Lundblad
petarj@mips.com writes: > > In any case, I'm not a good reviewer. Adding somebody from ...
6 years, 9 months ago (2014-03-12 16:59:47 UTC) #5
petarj
On 2014/03/12 16:59:47, Peter Lundblad wrote: > mailto:petarj@mips.com writes: > > > In any case, ...
6 years, 9 months ago (2014-03-12 17:09:04 UTC) #6
Peter Lundblad
lgtm I'm fine with this being added if it is going to be needed down ...
6 years, 9 months ago (2014-03-12 17:22:09 UTC) #7
petarj
The CQ bit was checked by petarj@mips.com
6 years, 9 months ago (2014-03-12 17:30:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/197613002/1
6 years, 9 months ago (2014-03-12 17:32:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 17:32:58 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-12 17:32:58 UTC) #11
Peter Lundblad
lgtm
6 years, 9 months ago (2014-03-12 17:34:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/197613002/1
6 years, 9 months ago (2014-03-12 17:35:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/197613002/1
6 years, 9 months ago (2014-03-12 19:26:38 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 20:54:47 UTC) #15
Message was sent while issue was closed.
Change committed as 256639

Powered by Google App Engine
This is Rietveld 408576698