Remove { delete this; } anti-pattern from IXFA_WidgetIterator

xfa/fxfa/include/xfa_ffpageview.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FXFA_INCLUDE_XFA_FFPAGEVIEW_H_
 #define XFA_FXFA_INCLUDE_XFA_FFPAGEVIEW_H_
 
 #include "xfa/fxfa/parser/xfa_doclayout.h"
@@ skipping 18 matching lines @@
                                 XFA_WIDGETFILTER_Viewable |
                                 XFA_WIDGETFILTER_AllType);
 
  protected:
   CXFA_FFDocView* const m_pDocView;
 };
 
 typedef CXFA_NodeIteratorTemplate<CXFA_LayoutItem,
                                   CXFA_TraverseStrategy_LayoutItem>
     CXFA_LayoutItemIterator;
+
 class CXFA_FFPageWidgetIterator : public IXFA_WidgetIterator {
  public:
   CXFA_FFPageWidgetIterator(CXFA_FFPageView* pPageView, uint32_t dwFilter);
-  virtual ~CXFA_FFPageWidgetIterator();
-
-  void Release() override { delete this; }
+  ~CXFA_FFPageWidgetIterator() override;
 
   void Reset() override;
   CXFA_FFWidget* MoveToFirst() override;
   CXFA_FFWidget* MoveToLast() override;
   CXFA_FFWidget* MoveToNext() override;
   CXFA_FFWidget* MoveToPrevious() override;
   CXFA_FFWidget* GetCurrentWidget() override;
   FX_BOOL SetCurrentWidget(CXFA_FFWidget* hWidget) override;
 
  protected:
@@ skipping 11 matching lines @@
   CXFA_TabParam() : m_pWidget(NULL) {}
   ~CXFA_TabParam() {}
 
   CXFA_FFWidget* m_pWidget;
   CXFA_WidgetArray m_Children;
 };
 class CXFA_FFTabOrderPageWidgetIterator : public IXFA_WidgetIterator {
  public:
   CXFA_FFTabOrderPageWidgetIterator(CXFA_FFPageView* pPageView,
                                     uint32_t dwFilter);
-  virtual ~CXFA_FFTabOrderPageWidgetIterator();
-
-  void Release() override;
+  ~CXFA_FFTabOrderPageWidgetIterator() override;
 
   void Reset() override;
   CXFA_FFWidget* MoveToFirst() override;
   CXFA_FFWidget* MoveToLast() override;
   CXFA_FFWidget* MoveToNext() override;
   CXFA_FFWidget* MoveToPrevious() override;
   CXFA_FFWidget* GetCurrentWidget() override;
   FX_BOOL SetCurrentWidget(CXFA_FFWidget* hWidget) override;
 
  protected:
@@ skipping 11 matching lines @@
                       FX_BOOL bMarsterPage = FALSE);
 
   CXFA_WidgetArray m_TabOrderWidgetArray;
   CXFA_FFPageView* m_pPageView;
   uint32_t m_dwFilter;
   int32_t m_iCurWidget;
   FX_BOOL m_bIgnorerelevant;
 };
 
 #endif  // XFA_FXFA_INCLUDE_XFA_FFPAGEVIEW_H_