Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Side by Side Diff: third_party/kasko/kasko.gyp

Issue 1976113003: Mark kasko as a hard dependency since it depends on kasko_features which generates a header file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 'targets': [ 2 'targets': [
3 { 3 {
4 # GN: //third_party/kasko:kasko_features 4 # GN: //third_party/kasko:kasko_features
5 'target_name': 'kasko_features', 5 'target_name': 'kasko_features',
6 'type': 'none', 6 'type': 'none',
7 'includes': [ '../../build/buildflag_header.gypi' ], 7 'includes': [ '../../build/buildflag_header.gypi' ],
8 'variables': { 8 'variables': {
9 'buildflag_header_path': 'third_party/kasko/kasko_features.h', 9 'buildflag_header_path': 'third_party/kasko/kasko_features.h',
10 'buildflag_flags': [ 10 'buildflag_flags': [
(...skipping 25 matching lines...) Expand all
36 '<(kasko_exe_dir)/kasko.dll', 36 '<(kasko_exe_dir)/kasko.dll',
37 '<(kasko_exe_dir)/kasko.dll.pdb', 37 '<(kasko_exe_dir)/kasko.dll.pdb',
38 ], 38 ],
39 }, 39 },
40 ], 40 ],
41 }, 41 },
42 { 42 {
43 # GN: //third_party/kasko 43 # GN: //third_party/kasko
44 'target_name': 'kasko', 44 'target_name': 'kasko',
45 'type': 'none', 45 'type': 'none',
46 'hard_dependency': 1,
blundell 2016/05/17 08:16:38 I don't think that this will fix the problem becau
46 'dependencies': [ 47 'dependencies': [
47 'copy_kasko_dll', 48 'copy_kasko_dll',
48 'kasko_features', 49 'kasko_features',
49 ], 50 ],
50 'direct_dependent_settings': { 51 'direct_dependent_settings': {
51 'msvs_settings': { 52 'msvs_settings': {
52 'VCLinkerTool': { 53 'VCLinkerTool': {
53 'AdditionalDependencies': [ 54 'AdditionalDependencies': [
54 'kasko.dll.lib', 55 'kasko.dll.lib',
55 ], 56 ],
(...skipping 18 matching lines...) Expand all
74 'target_name': 'kasko', 75 'target_name': 'kasko',
75 'type': 'none', 76 'type': 'none',
76 'dependencies': [ 77 'dependencies': [
77 'kasko_features', 78 'kasko_features',
78 ], 79 ],
79 }, 80 },
80 ], 81 ],
81 }], 82 }],
82 ], # 'conditions' 83 ], # 'conditions'
83 } 84 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698