Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: webkit/plugins/npapi/plugin_lib_unittest.cc

Issue 19761007: Move NPAPI implementation out of webkit/plugins/npapi and into content. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix mac Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/npapi/plugin_lib_unittest.cc
===================================================================
--- webkit/plugins/npapi/plugin_lib_unittest.cc (revision 212369)
+++ webkit/plugins/npapi/plugin_lib_unittest.cc (working copy)
@@ -1,66 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "webkit/plugins/npapi/plugin_lib.h"
-
-#include "base/strings/string_util.h"
-#include "base/strings/utf_string_conversions.h"
-#include "build/build_config.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace webkit {
-namespace npapi {
-
-// Test the unloading of plugin libs. Bug http://crbug.com/46526 showed that
-// if UnloadAllPlugins() simply iterates through the g_loaded_libs global
-// variable, we can get a crash if no plugin libs were marked as always loaded.
-class PluginLibTest : public PluginLib {
- public:
- PluginLibTest() : PluginLib(WebPluginInfo()) {}
- using PluginLib::Unload;
-
- protected:
- virtual ~PluginLibTest() {}
-};
-
-TEST(PluginLibLoading, UnloadAllPlugins) {
- // For the creation of the g_loaded_libs global variable.
- ASSERT_EQ(static_cast<PluginLibTest*>(NULL),
- PluginLibTest::CreatePluginLib(base::FilePath()));
-
- // Try with a single plugin lib.
- scoped_refptr<PluginLibTest> plugin_lib1(new PluginLibTest());
- PluginLib::UnloadAllPlugins();
-
- // Need to create it again, it should have been destroyed above.
- ASSERT_EQ(static_cast<PluginLibTest*>(NULL),
- PluginLibTest::CreatePluginLib(base::FilePath()));
-
- // Try with two plugin libs.
- plugin_lib1 = new PluginLibTest();
- scoped_refptr<PluginLibTest> plugin_lib2(new PluginLibTest());
- PluginLib::UnloadAllPlugins();
-
- // Need to create it again, it should have been destroyed above.
- ASSERT_EQ(static_cast<PluginLibTest*>(NULL),
- PluginLibTest::CreatePluginLib(base::FilePath()));
-
- // Now try to manually Unload one and then UnloadAll.
- plugin_lib1 = new PluginLibTest();
- plugin_lib2 = new PluginLibTest();
- plugin_lib1->Unload();
- PluginLib::UnloadAllPlugins();
-
- // Need to create it again, it should have been destroyed above.
- ASSERT_EQ(static_cast<PluginLibTest*>(NULL),
- PluginLibTest::CreatePluginLib(base::FilePath()));
-
- // Now try to manually Unload the only one and then UnloadAll.
- plugin_lib1 = new PluginLibTest();
- plugin_lib1->Unload();
- PluginLib::UnloadAllPlugins();
-}
-
-} // namespace npapi
-} // namespace webkit

Powered by Google App Engine
This is Rietveld 408576698