Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 19761007: Move NPAPI implementation out of webkit/plugins/npapi and into content. (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Move NPAPI implementation out of webkit/plugins/npapi and into content. Notes: -gtk_plugin_container_manager* and gtk_plugin_container* move to content/browser/renderer_host/ since that's all where they're used -plugin_list* and plugin_constants_win* move to content/common as they're used by child processes and the browser -webplugin_impl* and webplugin_page_delegate.h move to content/renderer as that's where they're used. I will remove webplugin_page_delegate.h in a followup change as it's no longer needed. -the rest moves to content/child/npapi -a few constants moved from plugin_constants_win.h to plugin_util.h temporarily BUG=237249 TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212485

Patch Set 1 #

Patch Set 2 : fix aura #

Patch Set 3 : fix mac #

Patch Set 4 : fix mac #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+648 lines, -14532 lines) Patch
M chrome/browser/hang_monitor/hung_plugin_action.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/plugin_loader_posix.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 14 chunks +22 lines, -24 lines 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + content/browser/renderer_host/gtk_plugin_container.h View 3 chunks +5 lines, -7 lines 0 comments Download
A + content/browser/renderer_host/gtk_plugin_container.cc View 2 chunks +3 lines, -5 lines 0 comments Download
A + content/browser/renderer_host/gtk_plugin_container_manager.h View 2 chunks +6 lines, -10 lines 0 comments Download
A + content/browser/renderer_host/gtk_plugin_container_manager.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 4 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 11 chunks +14 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 4 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_guest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
A + content/child/npapi/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/child/npapi/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/child/npapi/plugin_host.h View 5 chunks +7 lines, -10 lines 0 comments Download
A + content/child/npapi/plugin_host.cc View 8 chunks +14 lines, -17 lines 0 comments Download
A + content/child/npapi/plugin_instance.h View 3 chunks +5 lines, -7 lines 0 comments Download
A + content/child/npapi/plugin_instance.cc View 3 chunks +9 lines, -11 lines 0 comments Download
A + content/child/npapi/plugin_instance_mac.mm View 3 chunks +3 lines, -5 lines 0 comments Download
A + content/child/npapi/plugin_lib.h View 4 chunks +8 lines, -10 lines 0 comments Download
A + content/child/npapi/plugin_lib.cc View 2 chunks +6 lines, -8 lines 0 comments Download
A + content/child/npapi/plugin_lib_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
A + content/child/npapi/plugin_stream.h View 3 chunks +5 lines, -7 lines 0 comments Download
A + content/child/npapi/plugin_stream.cc View 3 chunks +4 lines, -6 lines 0 comments Download
A + content/child/npapi/plugin_stream_posix.cc View 2 chunks +4 lines, -6 lines 0 comments Download
A + content/child/npapi/plugin_stream_url.h View 2 chunks +4 lines, -6 lines 1 comment Download
A + content/child/npapi/plugin_stream_url.cc View 2 chunks +7 lines, -9 lines 0 comments Download
A + content/child/npapi/plugin_stream_win.cc View 2 chunks +4 lines, -6 lines 0 comments Download
A + content/child/npapi/plugin_string_stream.h View 2 chunks +6 lines, -8 lines 0 comments Download
A + content/child/npapi/plugin_string_stream.cc View 2 chunks +3 lines, -5 lines 0 comments Download
A + content/child/npapi/plugin_web_event_converter_mac.h View 3 chunks +5 lines, -7 lines 0 comments Download
A + content/child/npapi/plugin_web_event_converter_mac.mm View 3 chunks +3 lines, -5 lines 0 comments Download
A + content/child/npapi/webplugin.h View 4 chunks +5 lines, -37 lines 0 comments Download
A + content/child/npapi/webplugin_accelerated_surface_mac.h View 1 2 3 3 chunks +5 lines, -7 lines 0 comments Download
A + content/child/npapi/webplugin_delegate.h View 1 2 3 4 chunks +6 lines, -9 lines 0 comments Download
A + content/child/npapi/webplugin_delegate_impl.h View 1 2 3 6 chunks +7 lines, -26 lines 0 comments Download
A + content/child/npapi/webplugin_delegate_impl.cc View 3 chunks +6 lines, -8 lines 0 comments Download
A + content/child/npapi/webplugin_delegate_impl_android.cc View 2 chunks +5 lines, -7 lines 0 comments Download
A + content/child/npapi/webplugin_delegate_impl_aura.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
A + content/child/npapi/webplugin_delegate_impl_gtk.cc View 4 chunks +5 lines, -7 lines 0 comments Download
A + content/child/npapi/webplugin_delegate_impl_mac.mm View 3 chunks +9 lines, -10 lines 0 comments Download
A + content/child/npapi/webplugin_delegate_impl_win.cc View 14 chunks +23 lines, -77 lines 0 comments Download
A + content/child/npapi/webplugin_ime_win.h View 3 chunks +5 lines, -7 lines 0 comments Download
A + content/child/npapi/webplugin_ime_win.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M content/child/npobject_proxy.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M content/child/npobject_stub.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/child/npobject_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/plugin_param_traits.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + content/common/plugin_constants_win.h View 3 chunks +5 lines, -10 lines 0 comments Download
A + content/common/plugin_constants_win.cc View 2 chunks +3 lines, -6 lines 0 comments Download
A + content/common/plugin_list.h View 4 chunks +7 lines, -9 lines 0 comments Download
A + content/common/plugin_list.cc View 7 chunks +11 lines, -12 lines 0 comments Download
A + content/common/plugin_list_mac.mm View 3 chunks +5 lines, -5 lines 0 comments Download
A + content/common/plugin_list_posix.cc View 3 chunks +6 lines, -5 lines 0 comments Download
A + content/common/plugin_list_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
A + content/common/plugin_list_win.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/common/view_messages.h View 4 chunks +3 lines, -3 lines 0 comments Download
A content/common/webplugin_geometry.h View 1 chunk +47 lines, -0 lines 0 comments Download
A + content/common/webplugin_geometry.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_child.gypi View 1 2 2 chunks +39 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 3 chunks +19 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 6 chunks +5 lines, -3 lines 0 comments Download
M content/plugin/plugin_channel.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/plugin/plugin_interpose_util_mac.mm View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M content/plugin/plugin_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_thread.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M content/plugin/webplugin_accelerated_surface_proxy_mac.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 2 chunks +2 lines, -7 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M content/plugin/webplugin_proxy.h View 8 chunks +10 lines, -19 lines 0 comments Download
M content/plugin/webplugin_proxy.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 3 chunks +2 lines, -7 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/render_process_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 9 chunks +9 lines, -14 lines 0 comments Download
M content/renderer/render_widget.h View 3 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.h View 6 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 6 chunks +5 lines, -7 lines 0 comments Download
A + content/renderer/webplugin_impl.h View 7 chunks +14 lines, -16 lines 0 comments Download
A + content/renderer/webplugin_impl.cc View 5 chunks +7 lines, -9 lines 0 comments Download
A + content/renderer/webplugin_impl_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
A + content/renderer/webplugin_page_delegate.h View 4 chunks +6 lines, -9 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webkit/glue/webkitplatformsupport_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webkit/plugins/npapi/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D webkit/plugins/npapi/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D webkit/plugins/npapi/gtk_plugin_container.h View 1 chunk +0 lines, -32 lines 0 comments Download
D webkit/plugins/npapi/gtk_plugin_container.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D webkit/plugins/npapi/gtk_plugin_container_manager.h View 1 chunk +0 lines, -62 lines 0 comments Download
D webkit/plugins/npapi/gtk_plugin_container_manager.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D webkit/plugins/npapi/plugin_constants_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webkit/plugins/npapi/plugin_constants_win.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D webkit/plugins/npapi/plugin_host.h View 1 chunk +0 lines, -63 lines 0 comments Download
D webkit/plugins/npapi/plugin_host.cc View 1 chunk +0 lines, -1113 lines 0 comments Download
D webkit/plugins/npapi/plugin_instance.h View 1 chunk +0 lines, -374 lines 0 comments Download
D webkit/plugins/npapi/plugin_instance.cc View 1 chunk +0 lines, -689 lines 0 comments Download
D webkit/plugins/npapi/plugin_instance_mac.mm View 1 chunk +0 lines, -108 lines 0 comments Download
D webkit/plugins/npapi/plugin_lib.h View 1 chunk +0 lines, -135 lines 0 comments Download
D webkit/plugins/npapi/plugin_lib.cc View 1 chunk +0 lines, -337 lines 0 comments Download
D webkit/plugins/npapi/plugin_lib_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D webkit/plugins/npapi/plugin_list.h View 1 chunk +0 lines, -253 lines 0 comments Download
D webkit/plugins/npapi/plugin_list.cc View 1 chunk +0 lines, -448 lines 0 comments Download
D webkit/plugins/npapi/plugin_list_mac.mm View 1 chunk +0 lines, -305 lines 0 comments Download
D webkit/plugins/npapi/plugin_list_posix.cc View 1 chunk +0 lines, -595 lines 0 comments Download
D webkit/plugins/npapi/plugin_list_unittest.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D webkit/plugins/npapi/plugin_list_win.cc View 1 chunk +0 lines, -465 lines 0 comments Download
D webkit/plugins/npapi/plugin_stream.h View 1 chunk +0 lines, -161 lines 0 comments Download
D webkit/plugins/npapi/plugin_stream.cc View 1 chunk +0 lines, -289 lines 0 comments Download
D webkit/plugins/npapi/plugin_stream_posix.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D webkit/plugins/npapi/plugin_stream_url.h View 1 chunk +0 lines, -74 lines 0 comments Download
D webkit/plugins/npapi/plugin_stream_url.cc View 1 chunk +0 lines, -164 lines 0 comments Download
D webkit/plugins/npapi/plugin_stream_win.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D webkit/plugins/npapi/plugin_string_stream.h View 1 chunk +0 lines, -42 lines 0 comments Download
D webkit/plugins/npapi/plugin_string_stream.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M webkit/plugins/npapi/plugin_utils.h View 2 chunks +20 lines, -0 lines 0 comments Download
M webkit/plugins/npapi/plugin_utils.cc View 2 chunks +68 lines, -0 lines 0 comments Download
D webkit/plugins/npapi/plugin_web_event_converter_mac.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webkit/plugins/npapi/plugin_web_event_converter_mac.mm View 1 chunk +0 lines, -190 lines 0 comments Download
D webkit/plugins/npapi/webplugin.h View 1 chunk +0 lines, -198 lines 0 comments Download
D webkit/plugins/npapi/webplugin.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D webkit/plugins/npapi/webplugin_accelerated_surface_mac.h View 1 chunk +0 lines, -41 lines 0 comments Download
D webkit/plugins/npapi/webplugin_delegate.h View 1 chunk +0 lines, -139 lines 0 comments Download
D webkit/plugins/npapi/webplugin_delegate_impl.h View 1 chunk +0 lines, -507 lines 0 comments Download
D webkit/plugins/npapi/webplugin_delegate_impl.cc View 1 chunk +0 lines, -310 lines 0 comments Download
D webkit/plugins/npapi/webplugin_delegate_impl_android.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D webkit/plugins/npapi/webplugin_delegate_impl_aura.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D webkit/plugins/npapi/webplugin_delegate_impl_gtk.cc View 1 chunk +0 lines, -753 lines 0 comments Download
D webkit/plugins/npapi/webplugin_delegate_impl_mac.mm View 1 chunk +0 lines, -730 lines 0 comments Download
D webkit/plugins/npapi/webplugin_delegate_impl_win.cc View 1 chunk +0 lines, -1547 lines 0 comments Download
D webkit/plugins/npapi/webplugin_ime_win.h View 1 chunk +0 lines, -185 lines 0 comments Download
D webkit/plugins/npapi/webplugin_ime_win.cc View 1 chunk +0 lines, -325 lines 0 comments Download
D webkit/plugins/npapi/webplugin_impl.h View 1 chunk +0 lines, -342 lines 0 comments Download
D webkit/plugins/npapi/webplugin_impl.cc View 1 chunk +0 lines, -1448 lines 0 comments Download
D webkit/plugins/npapi/webplugin_impl_unittest.cc View 1 chunk +0 lines, -234 lines 0 comments Download
D webkit/plugins/npapi/webplugin_page_delegate.h View 1 chunk +0 lines, -73 lines 0 comments Download
M webkit/plugins/webkit_plugins.gyp View 2 chunks +0 lines, -17 lines 0 comments Download
M webkit/plugins/webkit_plugins.gypi View 2 chunks +0 lines, -61 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
Apologies for the size of this change. I had tried to find a way to ...
7 years, 5 months ago (2013-07-18 23:04:45 UTC) #1
scottmg
lgtm
7 years, 5 months ago (2013-07-19 02:16:01 UTC) #2
scottmg
7 years, 5 months ago (2013-07-19 02:23:46 UTC) #3
Message was sent while issue was closed.
https://codereview.chromium.org/19761007/diff/39001/content/child/npapi/plugi...
File content/child/npapi/plugin_stream_url.h (right):

https://codereview.chromium.org/19761007/diff/39001/content/child/npapi/plugi...
content/child/npapi/plugin_stream_url.h:5: #ifndef
WEBKIT_PLUGINS_NPAPI_PLUGIN_STREAM_URL_H_
missed updating header guard here

Powered by Google App Engine
This is Rietveld 408576698