Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1976063002: More work on ServiceProviderImpl. (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

More work on ServiceProviderImpl. * Remove the old AddService<I>(). * Rename AddServiceNew<I>() to AddService<I>(). * Add a getter for the ConnectionContext. * Add a AddServiceForName() that takes a ServiceConnector. * Add RemoveService<I>() and RemoveServiceForName(). The additions are basically required to replace the current ServiceProvider implementation in stuff in ServiceRegistry with just a ServiceProviderImpl. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/90ee9b339c3304a5bb84bbf75e4b926aa1577af8

Patch Set 1 #

Patch Set 2 : doh #

Patch Set 3 : sigh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -33 lines) Patch
M apps/moterm/moterm_view.h View 3 chunks +0 lines, -7 lines 0 comments Download
M apps/moterm/moterm_view.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M mojo/public/cpp/application/service_provider_impl.h View 1 2 4 chunks +29 lines, -15 lines 0 comments Download
M mojo/public/cpp/application/tests/service_provider_impl_unittest.cc View 8 chunks +55 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-13 00:02:41 UTC) #1
vardhan
lgtm
4 years, 7 months ago (2016-05-13 00:26:16 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-13 15:59:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
90ee9b339c3304a5bb84bbf75e4b926aa1577af8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698