Issue 197603002: Turn StringLengthStub (used by string wrappers only) into a hydrogen stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 197603002: Turn StringLengthStub (used by string wrappers only) into a hydrogen stub. (Closed)

Created:
6 years, 9 months ago by Toon Verwaest

Modified:
6 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Turn StringLengthStub (used by string wrappers only) into a hydrogen stub. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19889

Patch Set 3 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -368 lines)			Patch
M	src/a64/code-stubs-a64.cc	View	1	2 chunks	+20 lines, -32 lines	0 comments	Download
M	src/a64/stub-cache-a64.cc	View	1 2	1 chunk	+0 lines, -54 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1	2 chunks	+20 lines, -31 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 2	1 chunk	+0 lines, -54 lines	0 comments	Download
M	src/code-stubs.h	View		5 chunks	+41 lines, -15 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	2 chunks	+20 lines, -20 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+0 lines, -48 lines	0 comments	Download
M	src/ic.cc	View	1	2 chunks	+11 lines, -25 lines	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	2 chunks	+20 lines, -29 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2	1 chunk	+0 lines, -48 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

lgtm with a nit https://codereview.chromium.org/197603002/diff/20001/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (right): https://codereview.chromium.org/197603002/diff/20001/src/x64/stub-cache-x64.cc#newcode284 src/x64/stub-cache-x64.cc:284: // Generate code to check ...

6 years, 9 months ago (2014-03-13 10:42:38 UTC) #2

Toon Verwaest

6 years, 9 months ago (2014-03-13 10:57:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19889 (presubmit successful).

Expand Messages | Collapse Messages

Issue 197603002: Turn StringLengthStub (used by string wrappers only) into a hydrogen stub. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages