Clean up CPDF_Creator.

Clean up CPDF_Creator.

- Used unique_ptr and initializer list.
- Remove variables that never change in value.

Committed: https://pdfium.googlesource.com/pdfium/+/e699c66433049396e438d983a1837b9d4a4cf766

[Lei Zhang, 2016-05-13 06:36:37]

Description was changed from

==========
Clean up CPDF_Creator.
==========

to

==========
Clean up CPDF_Creator.

- Used unique_ptr and initializer list.
- Remove variables that never change in value.
==========

[Lei Zhang, 2016-05-13 06:36:37]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2016-05-13 06:36:43]

https://codereview.chromium.org/1976003003/diff/1/core/fpdfapi/fpdf_edit/fpdf...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (left):

https://codereview.chromium.org/1976003003/diff/1/core/fpdfapi/fpdf_edit/fpdf...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:917: m_bEncryptMetadata = FALSE;
I accidentally removed this. It's always false.

https://codereview.chromium.org/1976003003/diff/1/core/fpdfapi/fpdf_edit/fpdf...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1976003003/diff/1/core/fpdfapi/fpdf_edit/fpdf...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:580: if (!pCreator->m_bCompress &&
!pCreator->m_pCryptoHandler) {
This always evals to false.

[Tom Sepez, 2016-05-13 20:05:11]

https://codereview.chromium.org/1976003003/diff/1/core/fpdfapi/fpdf_edit/fpdf...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (left):

https://codereview.chromium.org/1976003003/diff/1/core/fpdfapi/fpdf_edit/fpdf...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:917: m_bEncryptMetadata = FALSE;
On 2016/05/13 06:36:42, Lei Zhang wrote:
> I accidentally removed this. It's always false.
Accidentally? Otherwise, agreed its always false.

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:195: ASSERT(pDocument && pFile);
nit: pDocument de-ref'd below, move pFile assert as first thing in fn.

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:196: CPDF_Parser* pParser =
(CPDF_Parser*)pDocument->GetParser();
nit: cast not needed.

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:210: if (pFile->AppendString(("/"))
< 0) {
nit: OK, we can leave all these extra {} for another day, unless you're
ambitious.

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:1024: (pObj != m_pMetadata) ?
m_pCryptoHandler : nullptr;
nit: overparenthesized.

[Lei Zhang, 2016-05-14 01:06:33]

https://codereview.chromium.org/1976003003/diff/1/core/fpdfapi/fpdf_edit/fpdf...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (left):

https://codereview.chromium.org/1976003003/diff/1/core/fpdfapi/fpdf_edit/fpdf...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:917: m_bEncryptMetadata = FALSE;
On 2016/05/13 20:05:11, Tom Sepez wrote:
> On 2016/05/13 06:36:42, Lei Zhang wrote:
> > I accidentally removed this. It's always false.
> Accidentally? Otherwise, agreed its always false.

Accidentally removed in patch set 1. Should have been removed in patch set 2.

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
File core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp (right):

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:195: ASSERT(pDocument && pFile);
On 2016/05/13 20:05:11, Tom Sepez wrote:
> nit: pDocument de-ref'd below, move pFile assert as first thing in fn.

pFile also gets deref'd before being passed to anyone else.

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:196: CPDF_Parser* pParser =
(CPDF_Parser*)pDocument->GetParser();
On 2016/05/13 20:05:11, Tom Sepez wrote:
> nit: cast not needed.

Done.

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:210: if (pFile->AppendString(("/"))
< 0) {
On 2016/05/13 20:05:11, Tom Sepez wrote:
> nit: OK, we can leave all these extra {} for another day, unless you're
> ambitious.

There's too many in this file. Another day.

https://codereview.chromium.org/1976003003/diff/20001/core/fpdfapi/fpdf_edit/...
core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp:1024: (pObj != m_pMetadata) ?
m_pCryptoHandler : nullptr;
On 2016/05/13 20:05:11, Tom Sepez wrote:
> nit: overparenthesized.

Done.

[Tom Sepez, 2016-05-16 16:10:58]

lgtm

[Lei Zhang, 2016-05-16 18:36:54]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-05-16 18:36:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1976003003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1976003003/40001

[commit-bot: I haz the power, 2016-05-16 20:03:44]

Description was changed from

==========
Clean up CPDF_Creator.

- Used unique_ptr and initializer list.
- Remove variables that never change in value.
==========

to

==========
Clean up CPDF_Creator.

- Used unique_ptr and initializer list.
- Remove variables that never change in value.

Committed:
https://pdfium.googlesource.com/pdfium/+/e699c66433049396e438d983a1837b9d4a4c...
==========

[commit-bot: I haz the power, 2016-05-16 20:03:45]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/e699c66433049396e438d983a1837b9d4a4c...