Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1976003002: [MD settings] change i18n() use in html to $i18n (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, dcheng, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] change i18n() use in html to $i18n This CL switches i18n('') behavior use in html files to use $i18n instead. The i18n('') is still used in JavaScript files. These changes are mechanical changes. (Bonus, there a few i18n-content/i18n-values changes as well). BUG=611188 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46 Cr-Commit-Position: refs/heads/master@{#393587}

Patch Set 1 #

Patch Set 2 : line wrapping #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -74 lines) Patch
M chrome/browser/resources/settings/advanced_page/advanced_page.html View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.html View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/controls/settings_dropdown_menu.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/default_browser_page/default_browser_page.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/change_picture.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.html View 1 4 chunks +37 lines, -19 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 13 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/system_page/system_page.html View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
dschuyler
4 years, 7 months ago (2016-05-12 22:03:51 UTC) #4
Dan Beam
lgtm, but might want to wrap to 80 cols some places
4 years, 7 months ago (2016-05-12 22:06:24 UTC) #6
dpapad
Do all affected files still use i18n behavior in JS? If not can you remove ...
4 years, 7 months ago (2016-05-12 22:08:42 UTC) #7
dschuyler
On 2016/05/12 22:08:42, dpapad wrote: > Do all affected files still use i18n behavior in ...
4 years, 7 months ago (2016-05-12 22:28:13 UTC) #9
dpapad
lgtm
4 years, 7 months ago (2016-05-12 23:13:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1976003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1976003002/40001
4 years, 7 months ago (2016-05-13 18:17:04 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-13 18:29:22 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 18:30:23 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e031cc226e978981fb1589eaa20d3b635968d46
Cr-Commit-Position: refs/heads/master@{#393587}

Powered by Google App Engine
This is Rietveld 408576698